Pass event source to profiles

[ccutrer]

So that a user can define a profile that takes different actions depending on what's generating the command.

[Copilot]

Pull Request Overview

This PR extends the StateProfile interface to pass the event source to profiles, enabling users to define profiles that take different actions based on what generates the command.

• Adds a new overloaded onCommandFromItem method to StateProfile that accepts an optional source parameter
• Updates the CommunicationManager to pass the source parameter through the profile application chain
• Updates test cases to verify the new method signature and source parameter handling

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
StateProfile.java	Adds new overloaded method with source parameter and default implementation
CommunicationManager.java	Updates profile application methods to propagate source parameter
CommunicationManagerOSGiTest.java	Updates test verifications to match new method signature

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The javadoc is missing parameter documentation for the command parameter. Both parameters should be properly documented with @param tags.

Suggested change

	/**
	* Will be called if a command should be forwarded to the binding.
	*
	* @param command
	* @param command the command to forward

[holgerfriedrich]

LGTM, thanks!

[florian-h05]

Please don’t forget updating the docs.

[holgerfriedrich]

@florian-h05 Do you think we should extend this section of the docs and basically state that custom implementations of StateProfile can override onCommandFromItem to grab the event source?

[florian-h05]

Yes, would be good I think.

[florian-h05]

Ideally the ScriptProfile should support the source and inject it or pass it into the script.

[ccutrer]

Ideally the ScriptProfile should support the source and inject it or pass it into the script.

I'm not sure this is going to be possible. ScriptProfile just uses a TransformationService, and TransformationService can only accept one (unnamed) input parameter. Perhaps we could add a configuration option to the script profile that said "pass data as JSON", and then stuff both the command value and the source into a JSON structure before passing to the script? Seems kinda kludgey for some pretty advanced stuff. I'm able to utilize it easily because the JRuby helper library can directly create a profile, with optional named parameters.

[ccutrer]

@florian-h05 Do you think we should extend this section of the docs and basically state that custom implementations of StateProfile can override onCommandFromItem to grab the event source?

openhab/openhab-docs#2561

[florian-h05]

TransformationService can only accept one (unnamed) input parameter

What if we add a new method to it so we can optionally pass the second source parameter, and then inject the source into the script like it’s done with the arguments?