Skip to content

Upgrade jmdns to 3.6.1 - #4997

Merged
wborn merged 1 commit into
openhab:mainfrom
holgerfriedrich:pr-jmdns
Aug 30, 2025
Merged

Upgrade jmdns to 3.6.1#4997
wborn merged 1 commit into
openhab:mainfrom
holgerfriedrich:pr-jmdns

Conversation

@holgerfriedrich

Copy link
Copy Markdown
Member

Upgrades jmdns from 3.5.12 to 3.6.1.
Changelogs:
https://github.com/jmdns/jmdns/releases/tag/3.6.0
https://github.com/jmdns/jmdns/releases/tag/3.6.1

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>

@wborn wborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn
wborn merged commit 02804f8 into openhab:main Aug 30, 2025
5 checks passed
@wborn wborn added this to the 5.1 milestone Aug 30, 2025
@holgerfriedrich
holgerfriedrich deleted the pr-jmdns branch August 30, 2025 13:46
@holgerfriedrich

Copy link
Copy Markdown
Member Author

This is currently breaking mdns in the full distro.

Could not resolve module: org.openhab.core.io.transport.mdns [194] Unresolved requirement: Import-Package: javax.jmdns; version="[3.6.0,4.0.0)" -> Export-Package: javax.jmdns; bundle-symbolic-name="javax.jmdns"; bundle-version="3.6.1"; version="3.6.1" javax.jmdns [58] Unresolved requirement: Require-Capability: osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=8))"

I did not see it before, but in the full distro build, the following issue shows up in the log. mdns service is broken.

@kaikreuzer Do you have any hint how to resolve this? What changed towards 3.6? Version 3.5.12 works fine.

@kaikreuzer

Copy link
Copy Markdown
Member

@holgerfriedrich I am not aware of anything specific, but I see that the 3.6.0 release had quite many changes and clean-ups: https://github.com/jmdns/jmdns/releases/tag/3.6.0. So we might have to go through this to see why this new requirement came in - it should actually not ask for JavaSE 8, but just for anything >=8...

holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Aug 31, 2025
@holgerfriedrich

holgerfriedrich commented Aug 31, 2025

Copy link
Copy Markdown
Member Author

comparing the MANIFEST files:

grafik

apparently RequiredExecutionEnvironment changed from 1.8 to 8, whereas Require-Capability stayed at 1.8....

The change from 1.8 to 8 was done here:
jmdns/jmdns#326

@holgerfriedrich

Copy link
Copy Markdown
Member Author

@kaikreuzer I created a PR in jmdns to remove the require-capabilites info. Not sure if this is the way to go and I have not yet tested if this would solve our problem.
jmdns/jmdns#346

How should we proceed? Roll back in OH or go for changing jmdns?

@kaikreuzer

Copy link
Copy Markdown
Member

Thanks for the analysis @holgerfriedrich!
I'll test your fix right away and if it looks good, I could do a new jmdns release tonight - which should then be ok to be used in openHAB.

@holgerfriedrich

Copy link
Copy Markdown
Member Author

@kaikreuzer The line is gone in the manifest, but my OH test build still shows the same behavior with 3.6.2-SNAPSHOT :-(
So no need to release yet....

@kaikreuzer

Copy link
Copy Markdown
Member

Hm, that's sad to hear. Are you sure that it is using the right jar?
FWIW, I am just struggeling with the release because of https://central.sonatype.org/news/20250326_ossrh_sunset/. But I should be almost there to be able to do a release through the new mechanism.

@holgerfriedrich

Copy link
Copy Markdown
Member Author

When I remove Bundle-RequiredExecutionEnvironment: JavaSE-8 as well, it works well, the jmdns service changes from installed to active and all error messages are gone. This is probably not the right thing to do.

Regarding mvnrepo: I have no experience with deploying packages there....

@kaikreuzer

Copy link
Copy Markdown
Member

This is probably not the right thing to do.

It should not be necessary, but I have no idea, why this suddenly is a problem. Does it resolve again f you change it to JavaSE-1.8?

@kaikreuzer

Copy link
Copy Markdown
Member

Maybe worth to revert to 3.5.12 for now as we won't solve the issue today anymore...

@holgerfriedrich

holgerfriedrich commented Aug 31, 2025

Copy link
Copy Markdown
Member Author

@kaikreuzer I have the feeling, JavaSE-8 might not be a valid ee name: https://docs.osgi.org/reference/eenames.html

Regarding revert: Maybe we can wait for another day. Reverting means also to resolve add-ons again.
Snapshot will start, just mdns is broken.

@kaikreuzer

Copy link
Copy Markdown
Member

JavaSE-8 might not be a valid ee name

But we do not want EE, we only want SE...

@holgerfriedrich

Copy link
Copy Markdown
Member Author

@kaikreuzer jmdns/jmdns#350 does the trick for me.

@kaikreuzer

Copy link
Copy Markdown
Member

Great to hear. Then it is on me to get a release out. Trying my best here: https://github.com/jmdns/jmdns/actions/runs/17362951570/job/49285492295, but I won't manage to get it done tonight - so give me another chance tomorrow!

@kaikreuzer

Copy link
Copy Markdown
Member

I think I made it - the new version should appear on Maven Central within the next hour.
https://github.com/jmdns/jmdns/releases/tag/v3.6.2

@kaikreuzer

Copy link
Copy Markdown
Member

@andrewfg

andrewfg commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@holgerfriedrich / @kaikreuzer I am just checking some housekeeping in preparation for the OH v5.1 release and I am wondering if jmdns/jmdns#355 is included already in the Jmdns snapshot that will be used by OH in that upcoming release? Or do I need to do something on my side to make that happen?

Reason is that I have an addon PR openhab/openhab-addons#19340 which currently implements the jmdns/jmdns#355 code within the addon itself, whereas if it would become part of OH core then I can remove that code and import the functionality OH Core Jmdns instead.

@holgerfriedrich

Copy link
Copy Markdown
Member Author

@andrewfg checking https://github.com/jmdns/jmdns/commits/main/ it seems there has not been a jmdns release since then. So it is not included yet.

@kaikreuzer

Copy link
Copy Markdown
Member

@andrewfg I can do a new JmDNS release after openHAB 5.1, if that's ok.
I was actually still waiting/hoping for jmdns/jmdns#312, but it seems that this takes a while...

@andrewfg

Copy link
Copy Markdown
Contributor

No worries @kaikreuzer .. I will catch up whenever its ready..

@kaikreuzer

Copy link
Copy Markdown
Member

@andrewfg Just FTR, we are now on JmDNS 3.6.3: #5263

@andrewfg

Copy link
Copy Markdown
Contributor

Thanks @kaikreuzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants