Skip to content

[automation] Skip pre-compilation if rule engine not yet started - #5001

Merged
holgerfriedrich merged 1 commit into
openhab:mainfrom
florian-h05:precompile
Sep 7, 2025
Merged

[automation] Skip pre-compilation if rule engine not yet started#5001
holgerfriedrich merged 1 commit into
openhab:mainfrom
florian-h05:precompile

Conversation

@florian-h05

@florian-h05 florian-h05 commented Aug 31, 2025

Copy link
Copy Markdown
Contributor

Closes #4965.

As the rule engine needs to be started for the system to reach start level 40 and automation add-ons are not loaded before start level 80, skip pre-compilation if rule engine not yet started as automation add-ons are not available yet.

@florian-h05
[automation] Skip pre-compilation if rule engine not yet started
89d5ad8 
Closes openhab#4965.

As the rule engine needs to be started for the system to reach start level 40 and automation add-ons are not loaded before start level 80,
skip pre-compilation if rule engine not yet started as automation add-ons are not available yet.

Since the rule engine does not start

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05
florian-h05 requested a review from a team as a code owner August 31, 2025 16:46
@florian-h05 florian-h05 mentioned this pull request Aug 31, 2025
Closed
@holgerfriedrich

holgerfriedrich commented Sep 7, 2025

Copy link
Copy Markdown
Member

Just to give me some context, how will the rule compilation be triggerd, as it fails during activation of the rule?
Does it rely on onReadyMarkerAdded calling compileRules?

@holgerfriedrich holgerfriedrich added the bug An unexpected problem or unintended behavior of the Core label Sep 7, 2025
@florian-h05

florian-h05 commented Sep 7, 2025

Copy link
Copy Markdown
Contributor Author

Does it rely on onReadyMarkerAdded calling compileRules?

Exactly, this will trigger compilation of all rules on startup. Normally automation engines are available when the ready marker that registration is done for in the constructor of the RuleEngineIm is added.
If a rule is added later, it will be compiled through the activateRule method call.

holgerfriedrich
holgerfriedrich approved these changes Sep 7, 2025
View reviewed changes

@holgerfriedrich holgerfriedrich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the explanation

@holgerfriedrich
holgerfriedrich merged commit dc48fb8 into openhab:main Sep 7, 2025
5 checks passed
@holgerfriedrich holgerfriedrich added this to the 5.1 milestone Sep 7, 2025
@florian-h05
florian-h05 deleted the precompile branch September 7, 2025 15:37
@lolodomo

lolodomo commented Sep 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@florian-h05 I guess it should be backported to 5.0.x and then t can be without any risk?

@florian-h05

florian-h05 commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

No need to backport, as the false alarm error logs were already fixed by #4971.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

Assignees

No one assigned

Labels

bug An unexpected problem or unintended behavior of the Core

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

ScriptEngineManagerImpl invoked too early in the startup process

3 participants

@florian-h05 @holgerfriedrich @lolodomo