Persistence upgrader: Create default persistence settings if no configuration so far - #5212
Merged
Merged
Conversation
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Contributor
Author
|
@kaikreuzer I've tested this several times, both that it migrates the default strategies field as well that it created settings if no settings so far. |
Signed-off-by: Florian Hotze <dev@florianhotze.com>
kaikreuzer
added
the
bug
Contributor
|
Thank you very much for finishing this. |
Member
|
Unfortunately, we have missed one important situation here, which are textual configs. See openhab/openhab-webui#3123 (comment) |
Contributor
I don’t think we have, but it looks like there still is a bug with that, introduced in this change. |
Contributor
Author
|
See #5213. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5210.
Supersedes #5211 (fixes build, addresses Copilot review, minor enhancements).
Also-by: Mark Herwege mark.herwege@telenet.be
Signed-off-by: Florian Hotze dev@florianhotze.com