DSL Scripts and Rules: allow usage of org.openhab.core.automation.RuleManager

[dilyanpalauzov]

The changeset allows running from DSL Rules and DSL Sctipts a rule:

val ruleManagerBundleContext = org.osgi.framework.FrameworkUtil.getBundle(
    org.openhab.core.automation.RuleManager).bundleContext
val ruleManagerServiceReference = ruleManagerBundleContext.getServiceReference(
    org.openhab.core.automation.RuleManager)
val ruleManager = ruleManagerBundleContext.getService(ruleManagerServiceReference)

ruleManager.runNow("r2")

[lolodomo]

Why not ?

[lolodomo]

@Nadahar: is it something needed/expected for what is discussed about future for DSL rule/script?

[Nadahar]

This is done/needed in #5481 for the rule bundle, it's hard to see how it can hurt to also make it available to the script package - although I'm not sure exactly when/if that is needed.

I assume that @dilyanpalauzov knows why it's also needed for the script package.

[dilyanpalauzov]

It is needed in the scripts bundle, so that the above example can be executed in DSL Scripts, outside of DSL Rules. (You can try youself the snippet before and after changing core.module.script/bnd.bnd)

[lolodomo]

This is done/needed in #5481 for the rule bundle

Understood now that I read #5481. #5481 is more useful than this one and make this one useless.

With #5481, I understand that the code example in the current PR can simply be replaced by:

Rules.runRule(r2)

which is definitvely eaiser.

[Nadahar]

With #5481, I understand that the code example in the current PR can simply be replaced by:

Rules.runRule(r2)

which is definitvely eaiser.

Yes, it's easier, and #5481 also does many other things, like allowing to easily edit Item metadata for example. But, that doesn't make this "useless". This makes it possible to resolve classes in the automation bundle both from DSL rules and DSL scripts. #5481 "help you" make it convenient to do some of these things, but resolving the classes is still necessary.

What I don't know is why you'd want to do it from DSL scripts that isn't part of a rule, but that doesn't mean that it's wrong to make it possible.

[rkoshak]

What I don't know is why you'd want to do it from DSL scripts that isn't part of a rule, but that doesn't mean that it's wrong to make it possible.

E.g., access Item metadata in a DSL transformation to decide how to transform something.

[dilyanpalauzov]

What I don't know is why you'd want to do it from DSL scripts that isn't part of a rule

Writing DSL Script, which is part (action) of a UI rule, and thus not part of a DSL Rule, also needs the change in code.model.script/bnd.bnd. Compare to the problem description of #4784.

[Nadahar]

LGTM

[mherwege]

LGTM

[mherwege]

FTR: small patch exception