Fix DSL implicit contexts variables for '.rules' based rules - #5788
Open
Nadahar wants to merge 1 commit into
Open
Fix DSL implicit contexts variables for '.rules' based rules#5788Nadahar wants to merge 1 commit into
Nadahar wants to merge 1 commit into
Conversation
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Contributor
Author
|
Build failure is caused by a flaky test. |
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/how-to-evaluate-an-item-change-based-on-source-of-change/169715/28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little follow-up of #5607. It turns out that I forgot to include the implicit variables in the
model.rulebundle, so that they don't apply when a rule is parsed from a.rulesfile. This PR fixes that.Should be backported.