Fix WebSocket connection not working for HTTPS - #1738
Merged
Conversation
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Regression from openhab#1711. Fixes openhab/openhab-webui#3125. Signed-off-by: Florian Hotze <dev@florianhotze.com>
wborn
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #1711.
Fixes openhab/openhab-webui#3125.
WebSocket was not working over HTTPS, because ALPN only had h2 available as protocol, but WebSocket is based on http/1.1. This adds http/1.1 to ALPN and the required HttpConnectionFactory as well.
"Standard" HTTP requests over HTTPS continue to use HTTP/2, whilst WebSocket works as well.
Also adds links to related JavaDoc as it is super annoying to search for the JavaDoc every time you need it.