Skip to content

Increase default max size for thingHandler thread pool - #1785

Merged
kaikreuzer merged 1 commit into
openhab:mainfrom
lolodomo:increase_pool_size
Aug 17, 2025
Merged

Increase default max size for thingHandler thread pool#1785
kaikreuzer merged 1 commit into
openhab:mainfrom
lolodomo:increase_pool_size

Conversation

@lolodomo

@lolodomo lolodomo commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

Changed from 5 to 15.

Related to discussion in openhab/openhab-addons#19125

Changed from 5 to 15.

Related to discussion in openhab/openhab-addons#19125

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
lolodomo requested a review from a team as a code owner August 9, 2025 12:05
@lolodomo

lolodomo commented Aug 9, 2025

Copy link
Copy Markdown
Contributor Author

The idea would to backport that to OH 5.0 for next patch but not to 4.3.x to avoid impacting small machines with only 1 GB memory. We assume that OH 5 requires a server with more than 1 GB memory and so we can accept a bigger thread pool for bindings.

@lsiepel lsiepel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel added the enhancement An enhancement or new feature label Aug 11, 2025
@kaikreuzer
kaikreuzer merged commit e5dcb9d into openhab:main Aug 17, 2025
3 checks passed
@kaikreuzer kaikreuzer added this to the 5.1 milestone Aug 17, 2025
@kaikreuzer

Copy link
Copy Markdown
Member

I am not sure whether this is critical enough to backport to 5.0.x - if someone requires a bigger setting, they can easily change it manually. For all other 5.0 users, it would mean that memory usage is suddenly increased through a "small" patch only.

@lolodomo

Copy link
Copy Markdown
Contributor Author

I am now asking myself if 10 would not have been a better compromise?

@lsiepel

lsiepel commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

Maybe it is now that the exec also has its own threadpool. There is no magic formula, but smarthome in general, size of installations (requirement) and also the hardware (capacity) has grown over the past few years. An idle thread takes just a very small amount of memory, i wouldn't make a big deal of it.

@lolodomo
lolodomo deleted the increase_pool_size branch August 21, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants