Remove pax-web patching by openhab-util library - #1944
Merged
Conversation
This patching step has no longer worked for quite a while. `findResources` was removed from pax-web upstream in January 2020 (commit `cf6861615`, part of the PAXWEB-1190 Http/Whiteboard refactor), replaced by the current `findEntries(...)` methods - over a year and a half *before* pax-web `8.0.0` GA even shipped (September 2021). Every pax-web 8.0.x version has no method by that name. `ClassAdapter`'s method-matching (`"findResources".equals(name)`) therefore never fires, and `ClassPathUtilPatcher` has no verification step - it always prints `"Finished updating ..."` and exits 0 regardless of whether anything was actually patched. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
wborn
approved these changes
Aug 10, 2026
wborn
left a comment
wborn
left a comment
Member
There was a problem hiding this comment.
Nice to see it's no longer needed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patching step has no longer worked for quite a while.
findResourceswas removed from pax-web upstream in January 2020 (commitcf6861615, part of the PAXWEB-1190 Http/Whiteboard refactor), replaced by the currentfindEntries(...)methods - over a year and a half before pax-web8.0.0GA even shipped (September 2021). Every pax-web 8.0.x version has no method by that name.ClassAdapter's method-matching ("findResources".equals(name)) therefore never fires, andClassPathUtilPatcherhas no verification step - it always prints"Finished updating ..."and exits 0 regardless of whether anything was actually patched.@kaikreuzer Is seems you were right in openhab/openhab-util#1 (comment)