Sitemap editor: nested sitemaps#4206
Conversation
#5781 Bundle Size — 13.8MiB (+0.03%).7abfc75(current) vs 6e8e01e main#5775(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #5781 |
Baseline #5775 |
|
|---|---|---|
 Initial JS |
1.46MiB |
1.46MiB |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
0% |
0% |
| Chunks |
840 |
840 |
| Assets |
979 |
979 |
 Modules |
2721(+0.07%) |
2719 |
| Duplicate Modules |
0 |
0 |
| Duplicate Code |
0% |
0% |
| Packages |
122 |
122 |
| Duplicate Packages |
1 |
1 |
Bundle size by type 2 changes 
2 regressions
| Current #5781 |
Baseline #5775 |
|
|---|---|---|
| JS |
11.5MiB (+0.03%) |
11.5MiB |
| CSS |
896.59KiB (+0.03%) |
896.29KiB |
| IMG |
638.41KiB |
638.41KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| Other |
847B |
847B |
Bundle analysis report Branch mherwege:sitemap_nested Project dashboard
Generated by RelativeCI Documentation Report issue
florian-h05
added
enhancement
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
| openOnReady: Boolean, | ||
| disabled: Boolean | ||
| }, | ||
| emits: ['sitemapPicked', 'input'], |
There was a problem hiding this comment.
since sitempaPicked is an f7.emit, it shouldn't be listed here.
There was a problem hiding this comment.
i actually don't see where there is a f7.on sitemapPicked - maybe this is just here for consistency?
There was a problem hiding this comment.
This code is copied from persistencePicker I believe, so your feedback also may also apply to that one (and some other pickers). But all you point out is correct.
| }) | ||
| }, | ||
| methods: { | ||
| open() { |
There was a problem hiding this comment.
I don't see where 'open' is used, is it needed?
| title="Sitemap" | ||
| :value="widget.name" | ||
| :disabled="!editable" | ||
| @input="(value) => (widget.name = value)" /> |
There was a problem hiding this comment.
you can change the emit to be update:value instead of 'input'. That way, you can use vmodel:value="widget.name" which is shorthand for the 2 separate :value and @input lines.
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
3 participants
Depends on openhab/openhab-core#5543
This enhancement allows creating, editing and visualizing nested sitemaps in the sitemap editor. It requires the core enhancement to be merged.