oh-aggregate-series: Load look-back timeframe for diff_last/diff_first aggregation functions#4264
Draft
florian-h05 wants to merge 3 commits into
Draft
oh-aggregate-series: Load look-back timeframe for diff_last/diff_first aggregation functions#4264florian-h05 wants to merge 3 commits into
florian-h05 wants to merge 3 commits into
Conversation
#5932 Bundle Size — 13.88MiB (~+0.01%).971efd6(current) vs b715a2b main#5926(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #5932 |
Baseline #5926 |
|
|---|---|---|
 Initial JS |
1.47MiB |
1.47MiB |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
0% |
0% |
| Chunks |
843 |
843 |
| Assets |
982 |
982 |
| Modules |
2744 |
2744 |
| Duplicate Modules |
0 |
0 |
| Duplicate Code |
0% |
0% |
| Packages |
122 |
122 |
| Duplicate Packages |
1 |
1 |
Bundle size by type 
1 change 
1 regression
| Current #5932 |
Baseline #5926 |
|
|---|---|---|
| JS |
11.57MiB (~+0.01%) |
11.57MiB |
| CSS |
905.37KiB |
905.37KiB |
| IMG |
638.41KiB |
638.41KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| Other |
847B |
847B |
Bundle analysis report Branch florian-h05:oh-aggregate-series-... Project dashboard
Generated by RelativeCI Documentation Report issue
florian-h05
force-pushed
the
oh-aggregate-series-first-nan
branch
from
46fd1b5 to
a9932bc
Compare
…ot calculate value due to missing data Related to https://community.openhab.org/t/echart-problem-with-oh-aggregate-series/168922/23. Signed-off-by: Florian Hotze <dev@florianhotze.com>
…t/diff_first aggregation functions These need data from a previous time block to calculate their first value. Signed-off-by: Florian Hotze <dev@florianhotze.com>
…t/diff_first aggregation functions These need data from a previous time block to calculate their first value. Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
force-pushed
the
oh-aggregate-series-first-nan
branch
from
a9932bc to
971efd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff_lastanddiff_firstaggregation functions need data from before the start time to calculate their first value.Load this data from persistence to calculate the first aggregated value.
Also return
NaNfromdiff_lastinstead of 0 when unable to calculate aggregated value.Attempt to fix https://community.openhab.org/t/echart-problem-with-oh-aggregate-series/168922/23.