Skip to content

openapi spec - UIComponent missing optional slot#4340

Open
jsjames wants to merge 1 commit into
openhab:mainfrom
jsjames:fix-uicomponent
Open

openapi spec - UIComponent missing optional slot#4340
jsjames wants to merge 1 commit into
openhab:mainfrom
jsjames:fix-uicomponent

Conversation

@jsjames

@jsjames jsjames commented Jul 1, 2026

Copy link
Copy Markdown
Contributor
  • Updates the openapi spec to the latest from RC1
  • applies fixes to the spec to address missing optional slots in the UIComponent ([openapi] - UIComponent missing the slots element openhab-core#5686)
  • Also makes the slots optional in the RootUIComponent (since it is inherited from UIComponent)
  • fixed several typescript errors due to the change

@florian-h05, I'd like to get swagger to generate the slots correctly, but per the above issue, it is confused due to the recursive nature. Hopefully we can address that and then we can remove the tweaking of the openapi spec.

@jsjames jsjames requested review from florian-h05 and ghys as code owners July 1, 2026 18:37
@relativeci

relativeci Bot commented Jul 1, 2026

Copy link
Copy Markdown

#5980 Bundle Size — 13.88MiB (~-0.01%).

ab073a2(current) vs 36efc97 main#5975(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Improvement 1 improvement
                 Current
#5980
     Baseline
#5975
Improvement  Initial JS 1.47MiB(~-0.01%) 1.47MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 843 843
No change  Assets 982 982
No change  Modules 2742 2742
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 122 122
No change  Duplicate Packages 1 1
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#5980
     Baseline
#5975
Improvement  JS 11.57MiB (~-0.01%) 11.57MiB
No change  CSS 906.49KiB 906.49KiB
No change  IMG 638.41KiB 638.41KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  Other 847B 847B

Bundle analysis reportBranch jsjames:fix-uicomponentProject dashboard


Generated by RelativeCIDocumentationReport issue

@jsjames jsjames added this to the 5.3 milestone Jul 1, 2026
@jsjames jsjames force-pushed the fix-uicomponent branch from b33b460 to 4e7e764 Compare July 3, 2026 18:32
@jsjames jsjames added the rebuild trigger a new Jenkins job label Jul 3, 2026
@jsjames

jsjames commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@florian-h05 - i'm not sure why the Build failed - here? Also, I tried adding the rebuild label to see if this was just a fluke, but that doesn't seem to have any effect.

Signed-off-by: Jeff James <jeff@james-online.com>
@jsjames jsjames force-pushed the fix-uicomponent branch from 4e7e764 to ab073a2 Compare July 4, 2026 16:55
@jsjames

jsjames commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@florian-h05 - i'm not sure why the Build failed - here? Also, I tried adding the rebuild label to see if this was just a fluke, but that doesn't seem to have any effect.

You can ignore this, this was just a fluke in the build system so forced a new version and it built correctly.

However, I don't think the rebuild label is working correctly - not sure where this is looked at in the build system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rebuild trigger a new Jenkins job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant