Skip to content

oh-image - Allow embedding of SVG to oh-image and oh-image-card#4346

Open
jsjames wants to merge 3 commits into
openhab:mainfrom
jsjames:svg-actions
Open

oh-image - Allow embedding of SVG to oh-image and oh-image-card#4346
jsjames wants to merge 3 commits into
openhab:mainfrom
jsjames:svg-actions

Conversation

@jsjames

@jsjames jsjames commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Dependent on #4345

This adds support to embed SVGs to any oh-image and oh-image-card (in addition to oh-canvas-layout and oh-plan-page).

In addition:

  • converts the svg-embedded mixin to a composable which is reused across these components
  • converts oh-canvas-layout and oh-plan-page to composition api and typescript
  • adds appropriate svg-embedding fields in definitions (and adds some which were not listed, but are used in the ui)

Note:

  • For oh-image and oh-image-card, the embeddedSvgActions can only be edited in the code editor and not directly in the UI. To support editing in ui will be more involved as it will require more extensive changes throughout the widget editor and other components.
  • Also, during the typescript conversion of oh-canvas-layout, mutli-select drag/drop does not work on oh-canvas-layout #4324 was discovered where multi-select / moves is not working. This was not fixed in this PR and will be addressed separately.

jsjames added 2 commits July 3, 2026 11:32
Signed-off-by: Jeff James <jeff@james-online.com>
Squashed commits:
[8a8e4df59] ready for review

Signed-off-by: Jeff James <jeff@james-online.com>
[628643ee4] WIP
Signed-off-by: Jeff James <jeff@james-online.com>
@jsjames jsjames requested review from florian-h05 and ghys as code owners July 4, 2026 16:33
@jsjames jsjames added enhancement New feature or request main ui Main UI awaiting other PR Depends on another PR labels Jul 4, 2026
@relativeci

relativeci Bot commented Jul 4, 2026

Copy link
Copy Markdown

#5979 Bundle Size — 13.88MiB (-0.01%).

cb8e71e(current) vs 36efc97 main#5975(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#5979
     Baseline
#5975
Improvement  Initial JS 1.47MiB(-0.1%) 1.47MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 843 843
No change  Assets 982 982
Change  Modules 2751(+0.33%) 2742
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 122 122
No change  Duplicate Packages 1 1
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#5979
     Baseline
#5975
Improvement  JS 11.57MiB (-0.02%) 11.57MiB
No change  CSS 906.49KiB 906.49KiB
No change  IMG 638.41KiB 638.41KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  Other 847B 847B

Bundle analysis reportBranch jsjames:svg-actionsProject dashboard


Generated by RelativeCIDocumentationReport issue

Signed-off-by: Jeff James <jeff@james-online.com>

Signed-off-by: Jeff James <jeff@james-online.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting other PR Depends on another PR enhancement New feature or request main ui Main UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant