Install Grott proxy server

[andrewfg]

Resolves #2043

Todos:

• Add UI menu items for install/remove actions
• Get username from caller script variable, and parse IPv4 address
• Add test class, and pass on CI build
• Live test install/remove on virtual machine
• Live test install/remove on RPi5 clean install
• Add doc to openhabian.md
• Add doc to Growatt binding readme.md here

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

[andrewfg]

@mstormi status update

• the code is ready for your review
• it passes the CI build tests
• it installs and runs on an RPi VM on Windows
• however don't know how to build an SD card image to test on a real RPi => perhaps you can advise?
• initial tests failed due to non global python dependencies; now fixed
• paho-mqtt is required for grott.py to load (even if mqtt is disabled in the conf)
• sorry but I messed up the DCO sign off on the last commit
• this function uses menu option 2F; you needed to scroll down but window now resized
• added a one liner in the openhabian readme to describe this function
• it is planned to add something to the growatt binding readme too

[mstormi]

Thanks! Will review as soon as I find time.

See action tab/builds for an image or trigger build there but that's overkill, I'm fine if the BATS test is.

DCO no worries

docs yeah dunno myself maybe add a single sentence in docs/openhabian.md in the section with nginx, FIND etc.

window size it's one of the number arguments at the end of the whiptail cmd eventually both rtfm I'm on the phone and don't recall atm.

[mstormi]

thanks for your work so far
sorry for the inconvenience but code style compliance makes up for a major part of the overall work so we're strict on that.

[mstormi]

An openHABian system only has a single interface and doesn't do anything about it in oh config.

[mstormi]

=> So I think I have now fully addressed all of your issues.

Please no checklists type of report. Rather instead go through the review in GitHub and comment per-issue, otherwise it's too hard to keep track of which issue is still current

[andrewfg]

go through the review in GitHub and comment per-issue

I have done that. (as well)

[andrewfg]

@mstormi OK I am all finished now (hopefully) .. it passes all CI tests now (except DCO) plus also a live test on an RPi5 64 bit.

[andrewfg]

@mstormi it is not directly related to this PR but while testing the menu I noticed that there is another whiptail dialog that has a sizing issue..

[mstormi]

add your scroll comment and fix it while you're on it okay in this pr

ifc you find more open an own pr

[andrewfg]

fix it while you're on it okay in this pr

Ok. I am happy to fix it here. There are two ways to do it -- 1) widen the dialog, or 2) shorten the texts. => Do you prefer 1 or 2?

EDIT to be specific the problem is due to the overlong texts and caveats about the Java installations

[mstormi]

Ok. I am happy to fix it here. There are two ways to do it -- 1) widen the dialog, or 2) shorten the texts. => Do you prefer 1 or 2?

EDIT to be specific the problem is due to the overlong texts and caveats about the Java installations

2. please, it should not be more than 120 cols
   Maybe to replace "as Java provider" by "Java" is enough?

[andrewfg]

shorten the texts

Ok. Done. It is ready to go again.

[mstormi]

LGTM
Nice 1st contricbution.
Thanks a lot for your efforts!

[andrewfg]

thanks a lot for your efforts

Thanks for your support.