fix ESPHome install script - #2059
Merged
Merged
Conversation
…/ info messages Ready for testin on several operating systems
…openhabian into ESPHome-install-Script
…openhabian into ESPHome-install-Script
Signed-off-by: Patrick Götz <38883343+Oetzi-1987@users.noreply.github.com>
…openhabian into ESPHome-install-Script
…openhabian into ESPHome-install-Script
Signed-off-by: Patrick Götz <goetz.patrick@gmx.de>
Signed-off-by: Patrick Götz <goetz.patrick@gmx.de>
Signed-off-by: Patrick Götz <goetz.patrick@gmx.de>
Signed-off-by: Patrick Götz <goetz.patrick@gmx.det>
mstormi
requested changes
Sep 20, 2025
mstormi
left a comment
mstormi
left a comment
Contributor
There was a problem hiding this comment.
As also commented, like with any other 3rd party program, you should be offering Install, Remove and (if required) Setup as separate menu options.
Install and Remove to call install_xxx with arguments, Setup as a separate routine.
See CONTRIBUTING.md
packages.bats --> the test has not worked correct openhabian.md --> accepted the suggestion from @mstormi menu.sh --> accepted the restriction from @mstormi packages.bash --> update varaibla names to restrictions --> update script to get 2 options install / remove Signed-off-by: Patrick Götz <goetz.patrick@gmx.de>
mstormi
requested changes
Sep 29, 2025
packages.bash added check if python3 venv is already installed removed many comments in case that the same is wrtitten as echo some lines below made an if loop for install / update / remove whiptail menu in remove path is removed, all other whiptail messages are only shown if interactive mode is given update packages.bats additional update check Signed-off-by: Patrick Götz <goetz.patrick@gmx.de>
mstormi
previously approved these changes
Oct 9, 2025
Oetzi-1987
commented
Oct 10, 2025
Contributor
Author
There was a problem hiding this comment.
changes ok
Thank you!
@mstormi sorry for that question but is my first time with git do i have anything to do in this pull request?
Contributor
|
The DCO test is failing, you likely didnt sign all of your commits with a proper signage line I'll squash commits to resolve that but next time please remember to properly sign every commit . |
mstormi
approved these changes
Oct 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As already mentioned in the openhab community:
https://community.openhab.org/t/esphome-dashboard-instalation-problems/164237
and Git:
#1994
I fixed the install script, because there was alot of work in the Servicefile and the install script itself.
The Script is tested on RPI4 --> openhabian image / Debian 12 / Ubuntu 24.04 LTS
Also the Documentation is updatet and a hint for ESPHome was added
change the config file path to: "/etc/openhab/ESPHome"
The reason for this is that the files will be backuped with the openhab backup function