Fix LRSC reservation handling for aborted stores - #154
Merged
cfuguet merged 1 commit intoSep 11, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Add a directed regression test verifying that an aborted overlapping store preserves the LR reservation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes LR/SC reservation invalidation caused by aborted VIPT stores.
Changes:
- Gates LR/SC snooping with
~st1_req_abort. - No directed regression test was added for the aborted-store scenario.
File summaries
| File | Description |
|---|---|
rtl/src/hpdcache_ctrl.sv |
Prevents aborted stores from invalidating LR/SC reservations. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cfuguet
approved these changes
Sep 11, 2026
Contributor
|
Hi @Jackie425, Thank you for this contribution. This is indeed a performance bug, and your modification should fix it. I'm waiting for the non-regression tests to pass before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR attempts to fix #153 by preventing aborted VIPT stores from invalidating the LR/SC reservation. The failing test that reproduced this issue in my HPDcache UVM environment now passes with this fix.