Feature/more flexible batches - #77
Open
delcroip wants to merge 9 commits into
Open
Conversation
…role and location helpers - Import and use create_enrolment_officer_role() for dynamic role assignment instead of hardcoded ID - Add create_basic_test_locations() call in setUpClass for proper test environment initialization - Improves test reliability by avoiding hardcoded values and ensuring consistent location setup
…nt datetime - Changed the process_stamp filter from __lte=end_date to __lt=datetime.datetime.now() - This dynamically filters claims processed before the current time, potentially avoiding inclusion of claims at the exact end_date or improving real-time accuracy.
Fix invalid Django ORM field lookup in get_claim_queryset from 'process_stamp__is_null=False' to 'process_stamp__isnull=False'. The original '__is_null' is not a valid lookup, causing potential query issues; '__isnull' properly filters for non-null process_stamp values.
Replace hardcoded role ID `9` with dynamic `create_claim_admin_role()` to avoid environment-specific failures. Add `create_basic_test_locations()` call in `setUpClass` to ensure required location data exists before tests run. Fix `add_service_to_hf_pricelist` and `add_item_to_hf_pricelist` calls to pass `health_facility` object instead of `health_facility_id`.
…nup migration Move the RunPython operation for adding capitation payment entries from migration 0003 to 0007 to ensure it executes after schema updates. Also add migration 0009 to remove legacy fields such as legacy_id and location from the BatchRun model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BR is more a closing account function, it use legacy to resolve product (legacy) but this is not intuitive
this change will enable to keep the location approach but to add a "product" approach and later a program or enttity; the context "BatchPayment" might be rename later "closeAccount"
Type of Change
Related Issue(s) / Task(s)
Demo
Upload screenshots/gifs or link to any demo video here.
Checklist