Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion internal/rpc/conversation/conversation.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,21 @@ type conversationServer struct {

webhookClient *webhook.Client
userClient *rpcli.UserClient
msgClient *rpcli.MsgClient
msgClient messageClient
groupClient *rpcli.GroupClient
}

type messageClient interface {
GetMaxSeqs(ctx context.Context, conversationIDs []string) (map[string]int64, error)
GetMsgByConversationIDs(ctx context.Context, conversationIDs []string, maxSeqs map[string]int64) (map[string]*sdkws.MsgData, error)
GetHasReadSeqs(ctx context.Context, conversationIDs []string, userID string) (map[string]int64, error)
GetConversationsFullSyncSeqs(ctx context.Context, req *msg.GetConversationsFullSyncSeqsReq) (*msg.GetConversationsFullSyncSeqsResp, error)
SetUserConversationMaxSeq(ctx context.Context, conversationID string, ownerUserIDs []string, maxSeq int64) error
SetUserConversationMin(ctx context.Context, conversationID string, ownerUserIDs []string, minSeq int64) error
GetLastMessageSeqByTime(ctx context.Context, conversationID string, lastTime int64) (int64, error)
GetLastMessage(ctx context.Context, in *msg.GetLastMessageReq, opts ...grpc.CallOption) (*msg.GetLastMessageResp, error)
}

type Config struct {
RpcConfig config.Conversation
RedisConfig config.Redis
Expand Down
74 changes: 74 additions & 0 deletions internal/rpc/conversation/sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,22 @@ package conversation

import (
"context"
"time"

"github.com/openimsdk/open-im-server/v3/internal/rpc/incrversion"
"github.com/openimsdk/open-im-server/v3/pkg/authverify"
"github.com/openimsdk/open-im-server/v3/pkg/common/storage/model"
"github.com/openimsdk/open-im-server/v3/pkg/util/hashutil"
"github.com/openimsdk/protocol/conversation"
pbmsg "github.com/openimsdk/protocol/msg"
"github.com/openimsdk/protocol/sdkws"
"github.com/openimsdk/tools/utils/datautil"
)

var (
readInactiveConversationFilterEnabled = true
readInactiveConversationCountThreshold = 5000
readInactiveConversationDuration = int64((30 * 24 * time.Hour) / time.Millisecond)
)

func (c *conversationServer) GetFullOwnerConversationIDs(ctx context.Context, req *conversation.GetFullOwnerConversationIDsReq) (*conversation.GetFullOwnerConversationIDsResp, error) {
Expand All @@ -22,18 +32,82 @@ func (c *conversationServer) GetFullOwnerConversationIDs(ctx context.Context, re
if err != nil {
return nil, err
}
if shouldExcludeReadInactiveConversations(len(conversationIDs)) {
conversationIDs, err = c.excludeReadInactiveConversations(ctx, req.UserID, conversationIDs, readInactiveConversationDuration)
if err != nil {
return nil, err
}
}
total := int64(len(conversationIDs))
idHash := hashutil.IdHash(conversationIDs)
if req.IdHash == idHash {
conversationIDs = nil
} else if validPagination(req.GetPagination()) {
conversationIDs = datautil.Paginate(
conversationIDs,
int(req.GetPagination().GetPageNumber()),
int(req.GetPagination().GetShowNumber()),
)
}
return &conversation.GetFullOwnerConversationIDsResp{
Version: uint64(vl.Version),
VersionID: vl.ID.Hex(),
Equal: req.IdHash == idHash,
ConversationIDs: conversationIDs,
Total: total,
}, nil
}

func validPagination(pagination *sdkws.RequestPagination) bool {
return pagination != nil && pagination.GetPageNumber() > 0 && pagination.GetShowNumber() > 0
}

func shouldExcludeReadInactiveConversations(conversationCount int) bool {
return readInactiveConversationFilterEnabled &&
readInactiveConversationDuration > 0 &&
conversationCount > readInactiveConversationCountThreshold
}

func (c *conversationServer) excludeReadInactiveConversations(ctx context.Context, userID string, conversationIDs []string, inactiveDuration int64) ([]string, error) {
if len(conversationIDs) == 0 {
return nil, nil
}
pinnedConversationIDs, err := c.conversationDatabase.GetPinnedConversationIDs(ctx, userID)
if err != nil {
return nil, err
}
pinned := datautil.SliceSet(pinnedConversationIDs)
seqs, err := c.msgClient.GetConversationsFullSyncSeqs(ctx, &pbmsg.GetConversationsFullSyncSeqsReq{
UserID: userID,
ConversationIDs: conversationIDs,
})
if err != nil {
return nil, err
}
expireBefore := time.Now().UnixMilli() - inactiveDuration
filteredConversationIDs := make([]string, 0, len(conversationIDs))
for _, conversationID := range conversationIDs {
if _, ok := pinned[conversationID]; ok {
filteredConversationIDs = append(filteredConversationIDs, conversationID)
continue
}
seq := seqs.GetSeqs()[conversationID]
if seq == nil || !isReadInactiveConversation(seq, expireBefore) {
filteredConversationIDs = append(filteredConversationIDs, conversationID)
}
}
return filteredConversationIDs, nil
}

func isReadInactiveConversation(seq *pbmsg.FullSyncSeqs, expireBefore int64) bool {
if seq.GetMaxSeq() == 0 || seq.GetUserMinSeq() > seq.GetMaxSeq() {
return true
}
return seq.GetHasReadSeq() >= seq.GetMaxSeq() &&
seq.GetMaxSeqTime() > 0 &&
seq.GetMaxSeqTime() < expireBefore
}

func (c *conversationServer) GetIncrementalConversation(ctx context.Context, req *conversation.GetIncrementalConversationReq) (*conversation.GetIncrementalConversationResp, error) {
if err := authverify.CheckAccess(ctx, req.UserID); err != nil {
return nil, err
Expand Down
Loading
Loading