8381834: Improve TLAB sizing heuristics#30622
8381834: Improve TLAB sizing heuristics#30622albertnetymk wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
walulyai
left a comment
There was a problem hiding this comment.
For the log snippet showing the improvement, is this with ~1000 threads as described in the CR?
Yes, from running |
The patch introduces global allocation fraction tracking (
AdaptiveWeightedAverage) alongside per-thread allocation fraction. It uses observed global requested-size fraction to estimate initial per-thread TLAB size. Additionally, there's a temporary size boost (up to 16X) when refill pressure is high so threads with real allocation demand do not regress.I ran
MTLinkedListGC.javabefore and after the change. The largest effect is in debug builds: both Parallel and G1 end up with a much smaller heap, and many fewer GCs. Release builds also improve, although the gap is smaller there.Performance-neutral for DaCapo, SPECjbb2015, and SPECjvm2008. Also checked in
gc+tlab=debuglogs that the number of tlab refills are mostly on par.Test: tier1-5
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30622/head:pull/30622$ git checkout pull/30622Update a local copy of the PR:
$ git checkout pull/30622$ git pull https://git.openjdk.org/jdk.git pull/30622/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30622View PR using the GUI difftool:
$ git pr show -t 30622Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30622.diff
Using Webrev
Link to Webrev Comment