8381006: G1: Wrong IHOP old gen allocation rate calculation in presence of periodic gcs

[walulyai]

Hi,

Please review this patch to correctly reset Old gen allocation tracker.

Testing: gha

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8381006: G1: Wrong IHOP old gen allocation rate calculation in presence of periodic gcs (Bug - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30625/head:pull/30625
$ git checkout pull/30625

Update a local copy of the PR:
$ git checkout pull/30625
$ git pull https://git.openjdk.org/jdk.git pull/30625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30625

View PR using the GUI difftool:
$ git pr show -t 30625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30625.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381006: G1: Wrong IHOP old gen allocation rate calculation in presence of periodic gcs

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 988ec86: 8381838: java/net/DatagramSocket/SendReceiveMaxSize.java fails to compile after JDK-8381008
• cc1c427: 8380755: jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventG1.java fails gcId should be increasing
• 28a91d0: 8381795: AArch64: Optimized build is broken after JDK-8381003
• ... and 3 more: https://git.openjdk.org/jdk/compare/cfae18fa606d8924f1f020b0f2de8617dd648bb2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@walulyai The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (74dd53a1)