8380425: Support markwords in os::print_location#30627
Draft
stooke wants to merge 3 commits intoopenjdk:masterfrom
Draft
8380425: Support markwords in os::print_location#30627stooke wants to merge 3 commits intoopenjdk:masterfrom
stooke wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back stooke! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #8380425 by adding support for markwords. A test case is also added.
The current OpenJDK head will print out markwords as part of the oop print code, if the JDK is run with -XX:+WizardMode enabled.
The PR is not ready to be integrated as it will avoid the oop print code if a markword is detected. (i.e., it makes more sense to run this code atfer the oop detection/print code, if WizardMode is not enabled.)
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30627/head:pull/30627$ git checkout pull/30627Update a local copy of the PR:
$ git checkout pull/30627$ git pull https://git.openjdk.org/jdk.git pull/30627/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30627View PR using the GUI difftool:
$ git pr show -t 30627Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30627.diff