8381771: Add a check for DNS label not to end with a hyphen

[artur-oracle]

RFC 952 specifies that an LDH (Letter-Digit-Hyphen) label may only end with a letter or digit. We should remove hyphens from the set of permissible terminal characters in a label.

Also see:
https://www.icann.org/en/announcements/details/comment-concerning-trailing-hyphen-domain-names-7-1-2000-en

Also adding size checks while we touch this file.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8381771: Add a check for DNS label not to end with a hyphen (Sub-task - P4)

Reviewers

• Mikhail Yankelevich (@myankelev - Committer) 🔄 Re-review required (review applies to e7d2de35)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30628/head:pull/30628
$ git checkout pull/30628

Update a local copy of the PR:
$ git checkout pull/30628
$ git pull https://git.openjdk.org/jdk.git pull/30628/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30628

View PR using the GUI difftool:
$ git pr show -t 30628

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30628.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@artur-oracle The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b42e89a6)
• 00: Full (e7d2de35)

[myankelev]

This looks good to me.
However, I think testng tests will need to be changed to junit. Do you want to do it as a part of this ticket or I can create a bug and do it after this is merged. I don't mind either way.
What do you prefer?

[artur-oracle]

This looks good to me. However, I think testng tests will need to be changed to junit. Do you want to do it as a part of this ticket or I can create a bug and do it after this is merged. I don't mind either way. What do you prefer?

Hi @myankelev! Why would we want to change the test to use junit?

[myankelev]

This looks good to me. However, I think testng tests will need to be changed to junit. Do you want to do it as a part of this ticket or I can create a bug and do it after this is merged. I don't mind either way. What do you prefer?

Hi @myankelev! Why would we want to change the test to use junit?

We just tend to prefer junit and convert testng to it when we have a chance. This is the bug JDK-8307843.

I have created JDK-8381901, I will work on it after this PR is integrated.