8377819: Security properties jlink plugin#30635
8377819: Security properties jlink plugin#30635seanjmullan wants to merge 8 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back mullan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@seanjmullan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/label add security-libs |
|
@seanjmullan
|
|
/label add security |
|
@seanjmullan |
|
|
||
| Description | ||
| : Override the security properties in the `java.security` configuration | ||
| file with the properties in the specified file. |
There was a problem hiding this comment.
I think the description will need to be expanded a bit to make it very clear than the contents of the given file are used to override or add to the java.security that goes into the generated run-time image. Just trying to avoid anyone thinking it is somehow related to -Djava.security.properties to override the location of the file.
| ### Plugin `security-properties` | ||
|
|
||
| Options | ||
| : `--security-properties=*filename*` |
There was a problem hiding this comment.
I think the approach to use the contents as overrides is good. I'm just wondering if --security-properties is the best name as it initially looked like this sets the security properties when it's really more like an overlay/patch to override the values of existing properties, or add new properties, if you see what I mean.
This is a new jlink plugin which allows the user to specify values of security properties it wants to override in the
java.securityconfiguration file in a custom runtime image. This enhancement, along with thecacertsjlink plugin allow users to more easily create runtimes that address the specific security requirements of their applications.The command-line syntax takes a file containing properties that the user wants to override.
For example:
where
props.securityis a file containing one more more properties in thejava.securityfile syntax.Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30635/head:pull/30635$ git checkout pull/30635Update a local copy of the PR:
$ git checkout pull/30635$ git pull https://git.openjdk.org/jdk.git pull/30635/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30635View PR using the GUI difftool:
$ git pr show -t 30635Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30635.diff
Using Webrev
Link to Webrev Comment