Skip to content

8377819: Security properties jlink plugin#30635

Open
seanjmullan wants to merge 8 commits intoopenjdk:masterfrom
seanjmullan:open5
Open

8377819: Security properties jlink plugin#30635
seanjmullan wants to merge 8 commits intoopenjdk:masterfrom
seanjmullan:open5

Conversation

@seanjmullan
Copy link
Copy Markdown
Member

@seanjmullan seanjmullan commented Apr 8, 2026

This is a new jlink plugin which allows the user to specify values of security properties it wants to override in the java.security configuration file in a custom runtime image. This enhancement, along with the cacerts jlink plugin allow users to more easily create runtimes that address the specific security requirements of their applications.

The command-line syntax takes a file containing properties that the user wants to override.

For example:

jlink --security-properties props.security

where props.security is a file containing one more more properties in the java.security file syntax.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8381580 to be approved

Issues

  • JDK-8377819: Security properties jlink plugin (Enhancement - P4)
  • JDK-8381580: Security properties jlink plugin (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30635/head:pull/30635
$ git checkout pull/30635

Update a local copy of the PR:
$ git checkout pull/30635
$ git pull https://git.openjdk.org/jdk.git pull/30635/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30635

View PR using the GUI difftool:
$ git pr show -t 30635

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30635.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 8, 2026

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 8, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Apr 8, 2026
@seanjmullan seanjmullan marked this pull request as ready for review April 8, 2026 19:50
@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 8, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 8, 2026

@seanjmullan The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@seanjmullan
Copy link
Copy Markdown
Member Author

/label add security-libs

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 8, 2026

@seanjmullan
The label security-libs is not a valid label.
These labels are valid:

  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@seanjmullan
Copy link
Copy Markdown
Member Author

/label add security

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 8, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 8, 2026

@seanjmullan
The security label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 8, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 8, 2026

Webrevs


Description
: Override the security properties in the `java.security` configuration
file with the properties in the specified file.
Copy link
Copy Markdown
Contributor

@AlanBateman AlanBateman Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the description will need to be expanded a bit to make it very clear than the contents of the given file are used to override or add to the java.security that goes into the generated run-time image. Just trying to avoid anyone thinking it is somehow related to -Djava.security.properties to override the location of the file.

### Plugin `security-properties`

Options
: `--security-properties=*filename*`
Copy link
Copy Markdown
Contributor

@AlanBateman AlanBateman Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the approach to use the contents as overrides is good. I'm just wondering if --security-properties is the best name as it initially looked like this sets the security properties when it's really more like an overlay/patch to override the values of existing properties, or add new properties, if you see what I mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org csr Pull request needs approved CSR before integration rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants