8381900: Test vmTestbase/nsk/jvmti/scenarios/allocation/AP03/ap03t001 does not handle frequent GC gracefully#30644
Open
jsikstro wants to merge 1 commit intoopenjdk:masterfrom
Conversation
… does not handle frequent GC gracefully
|
👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
In the development of Automatic Heap Sizing (AHS) for ZGC we have seen vmTestbase/nsk/jvmti/scenarios/allocation/AP03/ap03t001 fail intermittently. The main thing in AHS affecting this test is the number of GCs being run. The ap03t001 test seems to not be able to reliably handle GC at any moment.
A naive solution to this problem is to just increase the min/initial heap size to give the test more headroom, but I think we should go with a more robust approach. What we're seeing in failing runs is that not only the "holder" object is beeing freed, but the test-object itself as well.
I propose we ignore ObjectFree events after having verified that the holder object has been resurrected into the catcher object, which is what this test is all about. Another alternative could be to disable ObjectFree events entirely after we're done, but I think this approach is easier to follow.
Testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30644/head:pull/30644$ git checkout pull/30644Update a local copy of the PR:
$ git checkout pull/30644$ git pull https://git.openjdk.org/jdk.git pull/30644/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30644View PR using the GUI difftool:
$ git pr show -t 30644Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30644.diff
Using Webrev
Link to Webrev Comment