fix(applyLayoutTransform): fix calculate matrix not include scrollLef…#1447
Open
pba-cra wants to merge 3 commits intoopenkraken:mainfrom
Open
fix(applyLayoutTransform): fix calculate matrix not include scrollLef…#1447pba-cra wants to merge 3 commits intoopenkraken:mainfrom
pba-cra wants to merge 3 commits intoopenkraken:mainfrom
Conversation
Author
我现在本地跑 test 好多报错啊 你们不报吗 |
Member
|
本地是有可能会报错的，你用 github 的 ci 跑吧，本地测试可以把某个要验证的 it 改成 fit。 |
andycall
reviewed
Jul 19, 2022
Member
|
这个情况还需要补充一个测试用例 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix error which calculate child to parent position not include scrollLeft and scrollTop