Archiving a TODO on the issue tracker instead of in code (#172).
|
# TODO: provide the possibility to return data even if save is set to false, |
|
# as the client code doesn't want to have to load the data again, |
|
# and may want to benefit from the caching of reordered data for future runs. |
I think it's a typo and is meant to say that it would return the data when save is set to True. Currently, in case the data is re-ordered and save=True, it is written to file and the file path is returned. The caller likely then would call the function again so that the data is actually loaded (or load the data from the provided path) -- that's just a lot of extra unnecessary work.
Archiving a TODO on the issue tracker instead of in code (#172).
automlbenchmark/amlb/datautils.py
Lines 184 to 186 in 98bf554
I think it's a typo and is meant to say that it would return the data when save is set to True. Currently, in case the data is re-ordered and
save=True, it is written to file and the file path is returned. The caller likely then would call the function again so that the data is actually loaded (or load the data from the provided path) -- that's just a lot of extra unnecessary work.