[orx-composition] no fill on open contours - #368
Closed
hamoid wants to merge 1 commit into
Closed
Conversation
Possible fix for #367
Member
|
Closing as I don't think this is the right place to address this. If there is a discrepancy between the drawing a contour and a contour converted to a shape then this problem also exists when outside of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #367
Only apply a fill color if all contours in the shape are closed.
Note: when a contour is drawn by orx-composition it is converted to a shape. This shape has only one contour.
This solution does not solve all discrepancies that are present when creating shapes that combine open and closed contours, reversed and not reversed, but it does fix issue #367 and renders well behaved shapes correctly.
I did not make edge cases behave exactly like the openrndr renderer because I'm not sure yet what is the desired behavior.