Skip to content

[orx-composition] no fill on open contours - #368

Closed
hamoid wants to merge 1 commit into
masterfrom
dontFillOpenContourSVG
Closed

[orx-composition] no fill on open contours#368
hamoid wants to merge 1 commit into
masterfrom
dontFillOpenContourSVG

Conversation

@hamoid

@hamoid hamoid commented Aug 4, 2025

Copy link
Copy Markdown
Member

Possible fix for #367

Only apply a fill color if all contours in the shape are closed.

Note: when a contour is drawn by orx-composition it is converted to a shape. This shape has only one contour.

This solution does not solve all discrepancies that are present when creating shapes that combine open and closed contours, reversed and not reversed, but it does fix issue #367 and renders well behaved shapes correctly.

I did not make edge cases behave exactly like the openrndr renderer because I'm not sure yet what is the desired behavior.

@edwinRNDR

Copy link
Copy Markdown
Member

Closing as I don't think this is the right place to address this. If there is a discrepancy between the drawing a contour and a contour converted to a shape then this problem also exists when outside of Composition and we should address it there.

@edwinRNDR edwinRNDR closed this Sep 1, 2025
@hamoid
hamoid deleted the dontFillOpenContourSVG branch March 24, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants