Skip to content

[orx-panel] Fix text input scroll, implement delete key #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hamoid wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[orx-panel] Fix text input scroll, implement delete key #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a198005
[orx-panel] Fix text input scroll, implement delete key
hamoid Aug 8, 2026
6ebe9e5
[orx-panel] Add selection to TextInput
hamoid Aug 10, 2026
ff2e296
[orx-panel] Add list of possible improvements
hamoid Aug 11, 2026
eb0e9c7
[orx-panel] Improve TextInput `scroll` calculation
hamoid Aug 12, 2026
2eb99d6
[orx-panel] Add single and double-click functionality
hamoid Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ folder, then executed. A PNG screenshot is saved and pushed into the [`media`](h
together with a link to the source code that produced the screenshot.

This serves two purposes: it can be useful for the user to see images of what the ORX can produce,
while it can also be usefu to detect breaking changes (in case the demo fails to run, or produces a
while it can also be useful to detect breaking changes (in case the demo fails to run or produces a
blank image).

## Gradle tasks
Expand Down
18 changes: 18 additions & 0 deletions orx-jvm/orx-gui/src/main/kotlin/custom/ElementExtensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ fun Element.uiForParameters(obj: Any): Div {
range = Range(parameter.intRange!!.start.toDouble(), parameter.intRange!!.endInclusive.toDouble())
label = parameter.label
precision = 0
@Suppress("UNCHECKED_CAST")
value = (parameter.property as KMutableProperty1<Any, Int>).get(obj).toDouble()
@Suppress("UNCHECKED_CAST")
bind(obj, parameter.property as KMutableProperty1<Any, Int>)
}
}
Expand All @@ -48,28 +50,38 @@ fun Element.uiForParameters(obj: Any): Div {
range = Range(parameter.doubleRange!!.start, parameter.doubleRange!!.endInclusive)
label = parameter.label
precision = parameter.precision!!
@Suppress("UNCHECKED_CAST")
value = (parameter.property as KMutableProperty1<Any, Double>).get(obj)
@Suppress("UNCHECKED_CAST")

bind(obj, parameter.property as KMutableProperty1<Any, Double>)
}
}
ParameterType.Color -> {
colorpickerButton {
label = parameter.label
@Suppress("UNCHECKED_CAST")
color = (parameter.property as KMutableProperty1<Any, ColorRGBa>).get(obj)
@Suppress("UNCHECKED_CAST")

bind(obj, parameter.property as KMutableProperty1<Any, ColorRGBa>)
}
}
ParameterType.Boolean -> {
toggle {
label = parameter.label
@Suppress("UNCHECKED_CAST")
value = (parameter.property as KMutableProperty1<Any, Boolean>).get(obj)
@Suppress("UNCHECKED_CAST")
bind(obj, parameter.property as KMutableProperty1<Any, Boolean>)
}
}
ParameterType.Text -> {
textfield {
label = parameter.label
@Suppress("UNCHECKED_CAST")
value = (parameter.property as KMutableProperty1<Any, String>).get(obj)
@Suppress("UNCHECKED_CAST")
bind(obj, parameter.property as KMutableProperty1<Any, String>)
}
}
Expand All @@ -79,7 +91,9 @@ fun Element.uiForParameters(obj: Any): Div {
label = parameter.label
range = parameter.doubleRange!!
precision = parameter.precision!!
@Suppress("UNCHECKED_CAST")
value = (parameter.property as KMutableProperty1<Any, Vector2>).get(obj)
@Suppress("UNCHECKED_CAST")
bind(obj, parameter.property as KMutableProperty1<Any, Vector2>)
}
}
Expand All @@ -89,7 +103,9 @@ fun Element.uiForParameters(obj: Any): Div {
label = parameter.label
range = parameter.doubleRange!!
precision = parameter.precision!!
@Suppress("UNCHECKED_CAST")
value = (parameter.property as KMutableProperty1<Any, Vector3>).get(obj)
@Suppress("UNCHECKED_CAST")
bind(obj, parameter.property as KMutableProperty1<Any, Vector3>)
}
}
Expand All @@ -99,7 +115,9 @@ fun Element.uiForParameters(obj: Any): Div {
label = parameter.label
range = parameter.doubleRange!!
precision = parameter.precision!!
@Suppress("UNCHECKED_CAST")
value = (parameter.property as KMutableProperty1<Any, Vector4>).get(obj)
@Suppress("UNCHECKED_CAST")
bind(obj, parameter.property as KMutableProperty1<Any, Vector4>)
}
}
Expand Down
Loading