SOFTWARE-6149: detect osg-configure changes for [Pilot] updates#125
Merged
brianhlin merged 4 commits intoopensciencegrid:masterfrom Jun 20, 2025
Merged
Conversation
matyasselmeci
approved these changes
Jun 20, 2025
Contributor
matyasselmeci
left a comment
matyasselmeci
left a comment
There was a problem hiding this comment.
A couple of small things; pre-approving
Co-authored-by: Matyas Selmeci <mselmeci@wisc.edu>
Co-authored-by: Matyas Selmeci <mselmeci@wisc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure that any of this is necessary: if updating the values file to update the ConfigMap restarts everything, then this is all moot. However, I can't readily test config propagation until we remove the subPath from the corresponding volume mount and I don't want to a) volumeMount over all of
/tmpor b) risk breaking all production CEs because the location of the source config file changed.