Add SQS source URL format validation and require External ID when role ARN is configured#7004
Open
Davidding4718 wants to merge 1 commit into
Open
Conversation
…e ARN is configured Signed-off-by: Siqi Ding <dingdd@amazon.com>
Davidding4718
requested review from
KarstenSchnitter,
Zhangxunmt,
dinujoh,
divbok,
dlvenable,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16,
srikanthjg and
srikanthpadakanti
as code owners
July 16, 2026 21:15
kkondaka
reviewed
Jul 17, 2026
| return awsStsHeaderOverrides; | ||
| } | ||
|
|
||
| @AssertTrue(message = "sts_external_id is required when sts_role_arn is specified to prevent confused deputy attacks. " + |
Collaborator
There was a problem hiding this comment.
I don't think we need this AssertTrue
Contributor
Author
|
Update: Both validations (URL format and External ID requirement) are already enforced at the service layer during pipeline creation, so this PR is supplementary — it adds plugin-level checks as an extra safety net but won't affect current behavior since invalid configs are already rejected upstream. Leaving this open in case the maintainers feel it's worth including as a best practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add input validation to the SQS source plugin to address two security concerns:
URL format validation (
QueueConfig): Add@Patternannotation to theurlfield to enforce that queue URLs match the canonical SQS endpoint format (https://sqs.<region>.amazonaws.com/<12-digit-account-id>/<queue-name>). This prevents arbitrary URLs from being submitted as queue configurations, mitigating potential Server-Side Request Forgery (SSRF) vectors.External ID requirement (
AwsAuthenticationOptions): Add@AssertTruevalidation that requiressts_external_idto be present and non-blank whensts_role_arnis configured. This mitigates the confused deputy problem where a pipeline could be configured to assume another account's IAM role without proper authorization.Both validations include corresponding unit tests.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.