MG-331: Promote the must-gather-operator from Tech Preview to GA - #378
MG-331: Promote the must-gather-operator from Tech Preview to GA#378neha037 wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@neha037: This pull request references MG-331 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (31)
WalkthroughThe PR introduces the MustGather v1 API, updates reconciliation and tests to use it, retains served v1alpha1 compatibility, changes v1 to the CRD storage version, publishes the operator through the stable bundle channel, and updates examples. ChangesMustGather v1 migration
Estimated code review effort: 4 (Complex) | ~45 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neha037 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 82.57% 81.94% -0.63%
==========================================
Files 9 10 +1
Lines 918 925 +7
==========================================
Hits 758 758
- Misses 148 155 +7
Partials 12 12
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
🧹 Nitpick comments (3)
api/v1/mustgather_types.go (1)
207-214: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win
patchStrategy/patchMergeKeystruct tags are inert for CRDs; use listType markers.For CRD-based APIs the merge semantics come from
+listType=map/+listMapKey=typemarkers, which controller-gen renders asx-kubernetes-list-typein the schema — the generated YAML currently emits a plain array. Adding them also lets Server-Side Apply merge conditions per type instead of replacing the whole list.♻️ Proposed change
- Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type"` + // +listType=map + // +listMapKey=type + // +patchStrategy=merge + // +patchMergeKey=type + // +optional + Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type"`🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@api/v1/mustgather_types.go` around lines 207 - 214, Update MustGatherStatus.Conditions to use CRD list markers +listType=map and +listMapKey=type, removing reliance on the inert patchStrategy and patchMergeKey tags. Ensure controller-gen emits x-kubernetes-list-type: map with type as the list map key so Server-Side Apply merges conditions by type.deploy/crds/operator.openshift.io_mustgathers.yaml (1)
17-17: 🗄️ Data Integrity & Integration | 🔵 TrivialStorage-version flip needs a storage migration before
v1alpha1can ever be dropped.Both versions carry identical schemas, so the implicit
strategy: Noneconversion is safe here. But existing objects stay etcd-encoded asv1alpha1, and the API server will appendv1alpha1tostatus.storedVersions. Keepingserved: true(as done) is correct; plan a storage migration (e.g. aStorageVersionMigrationor a read/write pass over all MustGathers) plus astoredVersionsprune before any future removal ofv1alpha1, otherwise the CRD update will be rejected.Also applies to: 319-323, 625-628
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@deploy/crds/operator.openshift.io_mustgathers.yaml` at line 17, Document and plan a storage migration for the MustGather CRD before removing v1alpha1: migrate existing objects to v1, then prune v1alpha1 from status.storedVersions. Keep v1alpha1 served during the migration and preserve the existing implicit None conversion behavior.bundle/manifests/stable/operator.openshift.io_mustgathers.yaml (1)
17-17: 🗄️ Data Integrity & Integration | 🔵 TrivialSame storage-version migration consideration as the
deploy/crdscopy. This is the manifest OLM applies on upgrade from the Tech Preview bundle, so it is the one that will populatestatus.storedVersionswith both versions on existing clusters.Also applies to: 625-628
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bundle/manifests/stable/operator.openshift.io_mustgathers.yaml` at line 17, Apply the same storage-version migration changes used in the deploy/crds copy to this OLM-applied manifest’s v1 version entry. Ensure upgrades from the Tech Preview bundle preserve both API versions in status.storedVersions and correctly transition the existing cluster’s storage version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bundle/manifests/stable/image-references`:
- Around line 2-4: Add the required metadata.name field to the ImageStream
manifest alongside kind and apiVersion, using the expected stable ImageStream
name; leave the existing spec unchanged.
In
`@bundle/manifests/stable/support-log-gather-operator.clusterserviceversion.yaml`:
- Line 59: Update the stable ClusterServiceVersion’s operator and must-gather
image references to immutable version tags or digests, replacing every mutable
:latest tag while preserving the existing GA image fields and structure.
In `@controllers/mustgather/mustgather_controller_test.go`:
- Line 13: Update the mustgatherv1 import usage in the must-gather controller
test so it matches the corrected api/v1 package definition and compiles
successfully. Inspect the referenced API types and adjust the import or affected
symbols consistently without changing the test’s behavior.
In `@controllers/mustgather/mustgather_image_test.go`:
- Line 10: Update the mustgatherv1 import usage in the test file to resolve the
api/v1 compilation failure, ensuring all references in the test remain
consistent with the corrected API package or symbols.
In `@controllers/mustgather/predicates_test.go`:
- Line 6: Update the mustgatherv1 import usage in the predicates tests to
resolve the api/v1 compilation failure, ensuring all references remain
consistent with the corrected API package symbols.
In `@controllers/mustgather/template_test.go`:
- Line 13: Update the mustgatherv1 import usage in the test file to resolve the
api/v1 compilation failure identified by static analysis. Ensure all references
in the test remain consistent with the corrected API package or symbols, without
changing unrelated test behavior.
In `@controllers/mustgather/template.go`:
- Line 16: Update the mustgatherv1 API types used by
controllers/mustgather/template.go so the imported api/v1 package compiles,
including implementing the required DeepCopyObject method on the affected
runtime.Object type. Preserve the existing mustgatherv1 import and controller
behavior.
In `@controllers/mustgather/trusted_ca_test.go`:
- Line 9: Update the mustgatherv1 import usage in trusted_ca_test.go to resolve
the api/v1 compilation failure identified by static analysis. Ensure all
references in this test use a currently valid, buildable API package or symbol
while preserving the test’s existing behavior.
---
Nitpick comments:
In `@api/v1/mustgather_types.go`:
- Around line 207-214: Update MustGatherStatus.Conditions to use CRD list
markers +listType=map and +listMapKey=type, removing reliance on the inert
patchStrategy and patchMergeKey tags. Ensure controller-gen emits
x-kubernetes-list-type: map with type as the list map key so Server-Side Apply
merges conditions by type.
In `@bundle/manifests/stable/operator.openshift.io_mustgathers.yaml`:
- Line 17: Apply the same storage-version migration changes used in the
deploy/crds copy to this OLM-applied manifest’s v1 version entry. Ensure
upgrades from the Tech Preview bundle preserve both API versions in
status.storedVersions and correctly transition the existing cluster’s storage
version.
In `@deploy/crds/operator.openshift.io_mustgathers.yaml`:
- Line 17: Document and plan a storage migration for the MustGather CRD before
removing v1alpha1: migrate existing objects to v1, then prune v1alpha1 from
status.storedVersions. Keep v1alpha1 served during the migration and preserve
the existing implicit None conversion behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: bf1049fb-b411-4fb8-bb26-46606eb6f187
⛔ Files ignored due to path filters (2)
api/v1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/v1/zz_generated.openapi.gois excluded by!**/zz_generated*
📒 Files selected for processing (31)
PROJECTapi/v1/groupversion_info.goapi/v1/mustgather_types.gobundle/bundle.Dockerfilebundle/manifests/art.yamlbundle/manifests/stable/image-referencesbundle/manifests/stable/operator.openshift.io_mustgathers.yamlbundle/manifests/stable/support-log-gather-operator.clusterserviceversion.yamlbundle/manifests/stable/trusted-ca.configmap.yamlbundle/manifests/support-log-gather-operator.package.yamlbundle/metadata/annotations.yamlconfig/templates/csv-template.yamlconfig/templates/must-gather-operator-csv-template.yamlcontrollers/mustgather/mustgather_controller.gocontrollers/mustgather/mustgather_controller_test.gocontrollers/mustgather/mustgather_image_test.gocontrollers/mustgather/predicates_test.gocontrollers/mustgather/template.gocontrollers/mustgather/template_test.gocontrollers/mustgather/trusted_ca_test.godeploy/crds/operator.openshift.io_mustgathers.yamlexamples/mustgather_basic.yamlexamples/mustgather_full.yamlexamples/mustgather_non_internal_user.yamlexamples/mustgather_retain_resources.yamlexamples/mustgather_timeout.yamlexamples/mustgather_with_pvc_subpath.yamlexamples/mustgather_with_since.yamlexamples/mustgather_with_sincetime.yamlmain.gotest/e2e/must_gather_operator_test.go
|
|
||
| imagev1 "github.com/openshift/api/image/v1" | ||
| mustgatherv1alpha1 "github.com/openshift/must-gather-operator/api/v1alpha1" | ||
| mustgatherv1 "github.com/openshift/must-gather-operator/api/v1" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
Same api/v1 build-blocking issue applies here.
This test file imports mustgatherv1, which currently fails to compile per static analysis. See consolidated comment.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@controllers/mustgather/mustgather_image_test.go` at line 10, Update the
mustgatherv1 import usage in the test file to resolve the api/v1 compilation
failure, ensuring all references in the test remain consistent with the
corrected API package or symbols.
Source: Linters/SAST tools
| "testing" | ||
|
|
||
| mustgatherv1alpha1 "github.com/openshift/must-gather-operator/api/v1alpha1" | ||
| mustgatherv1 "github.com/openshift/must-gather-operator/api/v1" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
Same api/v1 build-blocking issue applies here.
This test file imports mustgatherv1, which currently fails to compile per static analysis. See consolidated comment.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@controllers/mustgather/predicates_test.go` at line 6, Update the mustgatherv1
import usage in the predicates tests to resolve the api/v1 compilation failure,
ensuring all references remain consistent with the corrected API package
symbols.
Source: Linters/SAST tools
| "time" | ||
|
|
||
| mustgatherv1alpha1 "github.com/openshift/must-gather-operator/api/v1alpha1" | ||
| mustgatherv1 "github.com/openshift/must-gather-operator/api/v1" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
Same api/v1 build-blocking issue applies here.
This test file imports mustgatherv1, which currently fails to compile per static analysis. See consolidated comment.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@controllers/mustgather/template_test.go` at line 13, Update the mustgatherv1
import usage in the test file to resolve the api/v1 compilation failure
identified by static analysis. Ensure all references in the test remain
consistent with the corrected API package or symbols, without changing unrelated
test behavior.
Source: Linters/SAST tools
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| "github.com/openshift/must-gather-operator/api/v1alpha1" | ||
| mustgatherv1 "github.com/openshift/must-gather-operator/api/v1" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
Same api/v1 build-blocking issue applies here.
This file imports mustgatherv1, which currently fails to compile per static analysis (missing DeepCopyObject). See consolidated comment.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@controllers/mustgather/template.go` at line 16, Update the mustgatherv1 API
types used by controllers/mustgather/template.go so the imported api/v1 package
compiles, including implementing the required DeepCopyObject method on the
affected runtime.Object type. Preserve the existing mustgatherv1 import and
controller behavior.
Source: Linters/SAST tools
| "testing" | ||
|
|
||
| mustgatherv1alpha1 "github.com/openshift/must-gather-operator/api/v1alpha1" | ||
| mustgatherv1 "github.com/openshift/must-gather-operator/api/v1" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
Same api/v1 build-blocking issue applies here.
This test file imports mustgatherv1, which currently fails to compile per static analysis. See consolidated comment.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@controllers/mustgather/trusted_ca_test.go` at line 9, Update the mustgatherv1
import usage in trusted_ca_test.go to resolve the api/v1 compilation failure
identified by static analysis. Ensure all references in this test use a
currently valid, buildable API package or symbol while preserving the test’s
existing behavior.
Source: Linters/SAST tools
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 8
🧹 Nitpick comments (3)
api/v1/mustgather_types.go (1)
207-214: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win
patchStrategy/patchMergeKeystruct tags are inert for CRDs; use listType markers.For CRD-based APIs the merge semantics come from
+listType=map/+listMapKey=typemarkers, which controller-gen renders asx-kubernetes-list-typein the schema — the generated YAML currently emits a plain array. Adding them also lets Server-Side Apply merge conditions per type instead of replacing the whole list.♻️ Proposed change
- Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type"` + // +listType=map + // +listMapKey=type + // +patchStrategy=merge + // +patchMergeKey=type + // +optional + Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type"`🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@api/v1/mustgather_types.go` around lines 207 - 214, Update MustGatherStatus.Conditions to use CRD list markers +listType=map and +listMapKey=type, removing reliance on the inert patchStrategy and patchMergeKey tags. Ensure controller-gen emits x-kubernetes-list-type: map with type as the list map key so Server-Side Apply merges conditions by type.deploy/crds/operator.openshift.io_mustgathers.yaml (1)
17-17: 🗄️ Data Integrity & Integration | 🔵 TrivialStorage-version flip needs a storage migration before
v1alpha1can ever be dropped.Both versions carry identical schemas, so the implicit
strategy: Noneconversion is safe here. But existing objects stay etcd-encoded asv1alpha1, and the API server will appendv1alpha1tostatus.storedVersions. Keepingserved: true(as done) is correct; plan a storage migration (e.g. aStorageVersionMigrationor a read/write pass over all MustGathers) plus astoredVersionsprune before any future removal ofv1alpha1, otherwise the CRD update will be rejected.Also applies to: 319-323, 625-628
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@deploy/crds/operator.openshift.io_mustgathers.yaml` at line 17, Document and plan a storage migration for the MustGather CRD before removing v1alpha1: migrate existing objects to v1, then prune v1alpha1 from status.storedVersions. Keep v1alpha1 served during the migration and preserve the existing implicit None conversion behavior.bundle/manifests/stable/operator.openshift.io_mustgathers.yaml (1)
17-17: 🗄️ Data Integrity & Integration | 🔵 TrivialSame storage-version migration consideration as the
deploy/crdscopy. This is the manifest OLM applies on upgrade from the Tech Preview bundle, so it is the one that will populatestatus.storedVersionswith both versions on existing clusters.Also applies to: 625-628
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bundle/manifests/stable/operator.openshift.io_mustgathers.yaml` at line 17, Apply the same storage-version migration changes used in the deploy/crds copy to this OLM-applied manifest’s v1 version entry. Ensure upgrades from the Tech Preview bundle preserve both API versions in status.storedVersions and correctly transition the existing cluster’s storage version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bundle/manifests/stable/image-references`:
- Around line 2-4: Add the required metadata.name field to the ImageStream
manifest alongside kind and apiVersion, using the expected stable ImageStream
name; leave the existing spec unchanged.
In
`@bundle/manifests/stable/support-log-gather-operator.clusterserviceversion.yaml`:
- Line 59: Update the stable ClusterServiceVersion’s operator and must-gather
image references to immutable version tags or digests, replacing every mutable
:latest tag while preserving the existing GA image fields and structure.
In `@controllers/mustgather/mustgather_controller_test.go`:
- Line 13: Update the mustgatherv1 import usage in the must-gather controller
test so it matches the corrected api/v1 package definition and compiles
successfully. Inspect the referenced API types and adjust the import or affected
symbols consistently without changing the test’s behavior.
In `@controllers/mustgather/mustgather_image_test.go`:
- Line 10: Update the mustgatherv1 import usage in the test file to resolve the
api/v1 compilation failure, ensuring all references in the test remain
consistent with the corrected API package or symbols.
In `@controllers/mustgather/predicates_test.go`:
- Line 6: Update the mustgatherv1 import usage in the predicates tests to
resolve the api/v1 compilation failure, ensuring all references remain
consistent with the corrected API package symbols.
In `@controllers/mustgather/template_test.go`:
- Line 13: Update the mustgatherv1 import usage in the test file to resolve the
api/v1 compilation failure identified by static analysis. Ensure all references
in the test remain consistent with the corrected API package or symbols, without
changing unrelated test behavior.
In `@controllers/mustgather/template.go`:
- Line 16: Update the mustgatherv1 API types used by
controllers/mustgather/template.go so the imported api/v1 package compiles,
including implementing the required DeepCopyObject method on the affected
runtime.Object type. Preserve the existing mustgatherv1 import and controller
behavior.
In `@controllers/mustgather/trusted_ca_test.go`:
- Line 9: Update the mustgatherv1 import usage in trusted_ca_test.go to resolve
the api/v1 compilation failure identified by static analysis. Ensure all
references in this test use a currently valid, buildable API package or symbol
while preserving the test’s existing behavior.
---
Nitpick comments:
In `@api/v1/mustgather_types.go`:
- Around line 207-214: Update MustGatherStatus.Conditions to use CRD list
markers +listType=map and +listMapKey=type, removing reliance on the inert
patchStrategy and patchMergeKey tags. Ensure controller-gen emits
x-kubernetes-list-type: map with type as the list map key so Server-Side Apply
merges conditions by type.
In `@bundle/manifests/stable/operator.openshift.io_mustgathers.yaml`:
- Line 17: Apply the same storage-version migration changes used in the
deploy/crds copy to this OLM-applied manifest’s v1 version entry. Ensure
upgrades from the Tech Preview bundle preserve both API versions in
status.storedVersions and correctly transition the existing cluster’s storage
version.
In `@deploy/crds/operator.openshift.io_mustgathers.yaml`:
- Line 17: Document and plan a storage migration for the MustGather CRD before
removing v1alpha1: migrate existing objects to v1, then prune v1alpha1 from
status.storedVersions. Keep v1alpha1 served during the migration and preserve
the existing implicit None conversion behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: bf1049fb-b411-4fb8-bb26-46606eb6f187
⛔ Files ignored due to path filters (2)
api/v1/zz_generated.deepcopy.gois excluded by!**/zz_generated*api/v1/zz_generated.openapi.gois excluded by!**/zz_generated*
📒 Files selected for processing (31)
PROJECTapi/v1/groupversion_info.goapi/v1/mustgather_types.gobundle/bundle.Dockerfilebundle/manifests/art.yamlbundle/manifests/stable/image-referencesbundle/manifests/stable/operator.openshift.io_mustgathers.yamlbundle/manifests/stable/support-log-gather-operator.clusterserviceversion.yamlbundle/manifests/stable/trusted-ca.configmap.yamlbundle/manifests/support-log-gather-operator.package.yamlbundle/metadata/annotations.yamlconfig/templates/csv-template.yamlconfig/templates/must-gather-operator-csv-template.yamlcontrollers/mustgather/mustgather_controller.gocontrollers/mustgather/mustgather_controller_test.gocontrollers/mustgather/mustgather_image_test.gocontrollers/mustgather/predicates_test.gocontrollers/mustgather/template.gocontrollers/mustgather/template_test.gocontrollers/mustgather/trusted_ca_test.godeploy/crds/operator.openshift.io_mustgathers.yamlexamples/mustgather_basic.yamlexamples/mustgather_full.yamlexamples/mustgather_non_internal_user.yamlexamples/mustgather_retain_resources.yamlexamples/mustgather_timeout.yamlexamples/mustgather_with_pvc_subpath.yamlexamples/mustgather_with_since.yamlexamples/mustgather_with_sincetime.yamlmain.gotest/e2e/must_gather_operator_test.go
🛑 Comments failed to post (1)
bundle/manifests/stable/image-references (1)
2-4: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Add required ImageStream metadata.
This ImageStream lacks
metadata.name(orgenerateName), so the manifest is invalid for creation. Add the expected stable ImageStream name before publishing the bundle.Proposed fix
kind: ImageStream apiVersion: image.openshift.io/v1 +metadata: + name: support-log-gather-operator spec:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.kind: ImageStream apiVersion: image.openshift.io/v1 metadata: name: support-log-gather-operator spec:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bundle/manifests/stable/image-references` around lines 2 - 4, Add the required metadata.name field to the ImageStream manifest alongside kind and apiVersion, using the expected stable ImageStream name; leave the existing spec unchanged.
|
@neha037: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary by CodeRabbit
New Features
v1version.v1alpha1API for compatibility.Documentation