Skip to content

Add unit tests for AZ-aware struct and schema changes#480

Open
abhiramnarayana wants to merge 1 commit into
openstack-k8s-operators:mainfrom
abhiramnarayana:osprh-30644-unit-tests
Open

Add unit tests for AZ-aware struct and schema changes#480
abhiramnarayana wants to merge 1 commit into
openstack-k8s-operators:mainfrom
abhiramnarayana:osprh-30644-unit-tests

Conversation

@abhiramnarayana

Copy link
Copy Markdown
Contributor

Add tests to generate_bind9_pools_yaml_test.go verifying the data model and validation changes for AZ-aware multipool support protect against regressions. Covers view propagation to generated pool targets, template rendering of view and tsigkey_id fields (both inclusion when set and omission when empty), and AZ mode validation across all three enum states ("", "Disabled", "Enabled").

@openshift-ci openshift-ci Bot requested review from dprince and omersch381 June 18, 2026 07:53
@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhiramnarayana
Once this PR has been reviewed and has the lgtm label, please assign beagles for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Hi @abhiramnarayana. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omersch381

Copy link
Copy Markdown
Contributor

/ok-to-test

Add tests to generate_bind9_pools_yaml_test.go verifying the data
model and validation changes for AZ-aware multipool support protect
against regressions. Covers view propagation to generated pool targets,
template rendering of view and tsigkey_id fields (both inclusion
when set and omission when empty), and AZ mode validation across
all three enum states ("", "Disabled", "Enabled").

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Abhiram R N <abhiramrn@gmail.com>
@abhiramnarayana abhiramnarayana force-pushed the osprh-30644-unit-tests branch from f9a4ec7 to fe1b78f Compare June 18, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants