Skip to content

Remove enabled_backend entry from 00-config.conf#440

Open
fmount wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fmount:cleanup_template
Open

Remove enabled_backend entry from 00-config.conf#440
fmount wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fmount:cleanup_template

Conversation

@fmount

@fmount fmount commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

With webhooks we prevent the Glance deploy unless a backend is specified via customServiceConfig.
It doesn't fail if replicas is set to 0, but in general a backend must be specified.
This patch reinforce what already done by removing the enabled_backends information from 00-config.

Depends-On: openstack-k8s-operators/openstack-operator#1130

@konan-abhi konan-abhi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@abays

abays commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

/test precommit-check

@fmount

fmount commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

/test glance-operator-build-deploy-tempest

@openshift-ci openshift-ci Bot removed the lgtm label Feb 8, 2024
@openshift-ci openshift-ci Bot added the lgtm label Feb 8, 2024
@fmount

fmount commented Feb 8, 2024

Copy link
Copy Markdown
Contributor Author

/test glance-operator-build-deploy-kuttl

1 similar comment
@fmount

fmount commented Feb 9, 2024

Copy link
Copy Markdown
Contributor Author

/test glance-operator-build-deploy-kuttl

Comment thread templates/common/config/00-config.conf
@openshift-ci openshift-ci Bot removed the lgtm label Feb 12, 2024

@konan-abhi konan-abhi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@openshift-ci openshift-ci Bot added the lgtm label Feb 12, 2024

@abays abays left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fmount, konan-abhi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abays,fmount,konan-abhi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot removed the lgtm label Oct 11, 2024
@openshift-ci

openshift-ci Bot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@fmount

fmount commented Oct 11, 2024

Copy link
Copy Markdown
Contributor Author

/retest

With webhooks we prevent the glance deploy unless a backend is specified
via customServiceConfig. It doesn't fail if replicas is set to 0, but in
general a backend must be specified.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@openshift-ci

openshift-ci Bot commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

@fmount: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/glance-operator-build-deploy-tempest 12b786a link true /test glance-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants