Skip to content

Add missing condition in amphora controller when octavia-api is not ready#426

Open
gthiemonge wants to merge 1 commit into
openstack-k8s-operators:mainfrom
gthiemonge:fix_missing_condition
Open

Add missing condition in amphora controller when octavia-api is not ready#426
gthiemonge wants to merge 1 commit into
openstack-k8s-operators:mainfrom
gthiemonge:fix_missing_condition

Conversation

@gthiemonge

Copy link
Copy Markdown
Contributor

When the octavia-api service is not ready or not available, the flavor creation fails, it triggers a RequeueAfter 60 sec without any explanations (condition or logs)
Add a condition error to indicate the cause of the wait/failure.

@openshift-ci

openshift-ci Bot commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gthiemonge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Dec 6, 2024
…eady

When the octavia-api service is not ready or not available, the flavor
creation fails, it triggers a RequeueAfter 60 sec without any
explanations (condition or logs)
Add a condition error to indicate the cause of the wait/failure.
@gthiemonge gthiemonge force-pushed the fix_missing_condition branch from e20f786 to 391ed39 Compare December 6, 2024 09:22
@gthiemonge gthiemonge changed the title Add missing condition in amphora controller when octavia-api is ready Add missing condition in amphora controller when octavia-api is not ready Dec 6, 2024
@beagles

beagles commented Feb 28, 2025

Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@beagles

beagles commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

Is it time to close this PR ? :)

@openshift-ci

openshift-ci Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

@gthiemonge: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 391ed39 link true /test functional
ci/prow/precommit-check 391ed39 link true /test precommit-check
ci/prow/octavia-operator-build-deploy-kuttl 391ed39 link true /test octavia-operator-build-deploy-kuttl
ci/prow/images 391ed39 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants