Remove Kepler power monitoring agent#916
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlarriba The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post ❌ telemetry-openstack-meta-content-provider-master FAILURE in 34m 03s |
|
What about update. e.g. from FR5 to FR6? Shouldn't we have some sort of cleanup to remove the kepler scrapeconfig and dashboard? |
|
recheck |
Yeah, thats a good catch. I was thinking that the upgraded telemetry-operator will run a reconcile and during that it will automagically remove the created resources as they do not exist anymore in its vision, but you make me think that, as it does not know about them, it might just ignore them. |
jlarriba
force-pushed
the
remove-kepler-agent
branch
from
9bc9eae to
a270b1a
Compare
Kepler does not work in our deployment. Remove all Kepler code, configuration, dashboards, and scrape configs. Power monitoring now consists exclusively of ceilometer-ipmi. Also simplifies createComputeScrapeConfig by removing the suppressTLS workaround that was only needed for Kepler. Adds cleanup in reconcileUpdate to remove leftover Kepler resources from existing environments.
jlarriba
force-pushed
the
remove-kepler-agent
branch
from
a270b1a to
64a89e0
Compare
|
Build failed (check pipeline). Post ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 3h 12m 56s |
|
/retest |
|
recheck |
|
@jlarriba: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Build failed (check pipeline). Post ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 3h 26m 32s |
|
github-check is failing because the feature-verification-tests still reference kepler. You need to
|
|
Also, be aware (after my recent blunder with Depends-On). On telemetry-operator we use tide to merge PRs. Tide ignores Depends-On. So Tide would be happy to merge this PR once the CI passes even if the Depends-On FVT PR isn't merged yet, which would then block all other telemetry-operator PRs until the FVT PR merges as well. |
3 participants
Kepler does not work in our deployment. Remove all Kepler code, configuration, dashboards, and scrape configs. Power monitoring now consists exclusively of ceilometer-ipmi. Also simplifies createComputeScrapeConfig by removing the suppressTLS workaround that was only needed for Kepler.