DATA-5365: Fix case/punctuation-sensitive committee matching for USA events - #207
Merged
Merged
Conversation
Member
|
Interesting solution! I need to verify some local testing results with real data, but looks promising |
Member
|
LGTM - we'll need to go over openstates-core release procedure, but if you want to take a shot on Monday you can. It's a few steps. Basically:
|
jessemortenson
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the formatting-guessing heuristic with normalized comparison on both sides:
This normalization is applied identically to the incoming scraped name (in Python) and to Organization.name + every entry in Organization.other_names (via a Postgres regexp_replace/jsonb_array_elements SQL expression), so matches no longer depend on guessing exact formatting conventions.
Testing
Added test_related_committee_event_other_names_case_mismatch unit test.
All tests passed (351/351)
Manually verified against real scraped event data for TX and IL (different scrapers, different naming conventions), confirming committees resolve correctly despite case, punctuation, Oxford comma, and &/and differences - verified directly against a local Postgres DB via psql.