Add .gitignore entries for sensitive files#90
Open
pete-builds wants to merge 1 commit intoopenstreetmap-polska:mainfrom
Open
Add .gitignore entries for sensitive files#90pete-builds wants to merge 1 commit intoopenstreetmap-polska:mainfrom
pete-builds wants to merge 1 commit intoopenstreetmap-polska:mainfrom
Conversation
Member
|
I don't mind that but is there any reason for it aside defensive coding? |
Author
|
Mostly defensive, yeah. If someone clones the repo and has credential files locally (from a deploy key, SSL cert, etc.), these patterns keep them from getting committed by accident. No urgent reason beyond that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .gitignore is missing entries for private keys and credentials (
*.pem,*.key,*.p12,*.pfx,credentials.json,service-account*.json). Added those along with OS-specific files (.DS_Store,Thumbs.db) to help prevent accidental commits of sensitive material.The existing
cert/*entry covers certificates stored in that directory, but keys and credentials elsewhere in the tree weren't covered.