Skip to content

restrict url/website validation to specific tags #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrasd merged 5 commits into from
Apr 8, 2026
+30 −1
Merged

restrict url/website validation to specific tags #12178

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f935c8
restrict url validation to specific tags
bhavyaKhatri2703 Apr 7, 2026
410e641
move list of tag keys to osm/tags module
tyrasd Apr 8, 2026
66bb875
add test
tyrasd Apr 8, 2026
190d3f9
don't check wikimedia_commons for valid URLs
tyrasd Apr 8, 2026
9b8ce6e
add to changelog
tyrasd Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion modules/validations/invalid_format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,26 @@ export function validationFormatting() {
entityIds: [entity.id]
};

const urlValidationKeys = new Set([
'website',
'url',
'contact:website',
'contact:url',
'source:website',
'source:url',
'image',
'wikimedia_commons',
'brand:website',
'operator:website',
'network:website',
'website:en',
'website:fr',
'website:menu',
'post_office:website',
]);

Object.entries(entity.tags).map(function([key, tag]) {
if (!/\b(website|url)\b|^image$/i.test(key)) return null;
if (!urlValidationKeys.has(key)) return null;
if (!tag) return null;
const value = tag.trim();
if (!value) return null;
Expand Down