Skip to content

multipath-tools test: add missing include for stdint.h#117

Closed
fundawang wants to merge 1 commit into
opensvc:masterfrom
fundawang:patch-1
Closed

multipath-tools test: add missing include for stdint.h#117
fundawang wants to merge 1 commit into
opensvc:masterfrom
fundawang:patch-1

Conversation

@fundawang

Copy link
Copy Markdown

When building multipath-tools with cmocka 1.1.8. it produces following error when make test:

2025-07-18 14:42:21 In file included from test-log.c:6:
2025-07-18 14:42:21 test-log.c: In function '__wrap_dlog':
2025-07-18 14:42:21 test-log.c:24:20: error: 'uintptr_t' undeclared (first use in this function)
2025-07-18 14:42:21    24 |         expected = mock_ptr_type(char *);
2025-07-18 14:42:21       |                    ^~~~~~~~~~~~~
2025-07-18 14:42:21 test-log.c:10:1: note: 'uintptr_t' is defined in header '<stdint.h>'; did you forget to '#include <stdint.h>'?
2025-07-18 14:42:21     9 | #include "debug.h"
2025-07-18 14:42:21   +++ |+#include <stdint.h>
2025-07-18 14:42:21    10 | 
2025-07-18 14:42:21 test-log.c:24:20: note: each undeclared identifier is reported only once for each function it appears in
2025-07-18 14:42:21    24 |         expected = mock_ptr_type(char *);
2025-07-18 14:42:21       |                    ^~~~~~~~~~~~~
2025-07-18 14:42:21 test-log.c:24:20: error: expected ')' before '_mock'
2025-07-18 14:42:21    24 |         expected = mock_ptr_type(char *);
2025-07-18 14:42:21       |                    ^~~~~~~~~~~~~
2025-07-18 14:42:21 test-log.c:24:20: note: to match this '('
2025-07-18 14:42:21    24 |         expected = mock_ptr_type(char *);
2025-07-18 14:42:21       |                    ^~~~~~~~~~~~~
2025-07-18 14:42:21 make[1]: *** [Makefile:74: test-log.o] Error 1
2025-07-18 14:42:21 rm parser.o.wrap dmevents.o.wrap hwtable.o.wrap uevent.o.wrap blacklist.o.wrap util.o.wrap
2025-07-18 14:42:21 make[1]: Leaving directory '/home/lkp/rpmbuild/BUILD/multipath-tools-0.9.5/tests'
2025-07-18 14:42:21 make: *** [Makefile:121: test] Error 2
2025-07-18 14:42:21 error: Bad exit status from /var/tmp/rpm-tmp.7qc9Bd (%check)

The attached patch fixed this issue.

@bmarzins

Copy link
Copy Markdown
Collaborator

This patch looks fine, but we use an email workflow for patches. Could you please post this to dm-devel at lists.linux.dev
and CC myself (bmarzins at redhat dot com) and Martin Wilck (mwilck at suse dot com). Thanks.

@mwilck

mwilck commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

@fundawang: Sorry, we already had this patch in the openSUSE "tip" branch. If you don't mind, I'll just cherry-pick that one onto the queue branch.

@bmarzins, I believe that we don't have to enforce the email workflow for purely technical fixes like this. At least I have added some minor commits like this without formal mailing list review in the past.

@bmarzins

Copy link
Copy Markdown
Collaborator

@bmarzins, I believe that we don't have to enforce the email workflow for purely technical fixes like this. At least I have added some minor commits like this without formal mailing list review in the past.

@mwilck Sure. It's hard to see what kind of objection someone could have to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants