Skip to content

[tests] implement DinD test for SRP TC 2.6 Name Compression#3411

Merged
jwhui merged 1 commit into
openthread:mainfrom
jwhui:dind-srp-name-compression-test
Jun 11, 2026
Merged

[tests] implement DinD test for SRP TC 2.6 Name Compression#3411
jwhui merged 1 commit into
openthread:mainfrom
jwhui:dind-srp-name-compression-test

Conversation

@jwhui

@jwhui jwhui commented Jun 10, 2026

Copy link
Copy Markdown
Member

This commit implements the Thread 1.3 certification test case 2.4. [1.3] [CERT] Key Lease (1_3_SRP_TC_4) within the Docker-in-Docker testing framework.

Specifically, this adds:

  1. dind_srp_tc_4.exp: The Expect script executing the multi-node test procedure across BR_1 (DUT), ED_1 (Node 4), ED_2 (Node 5), and the adjacent infrastructure link test client.
  2. Hooked dind_srp_tc_4.exp into test_dind_dns_sd.sh runner script.

The test verifies that an SRP server correctly enforces key leases by rejecting service name and hostname takeovers when a service lease has expired but the associated key lease remains active (returning YXDomain). It also verifies that takeovers succeed once the key lease fully expires.

@jwhui jwhui changed the title Dind srp name compression test [tests] implement SRP Key Lease (1_3_SRP_TC_4) DinD integration test Jun 10, 2026
gemini-code-assist[bot]

This comment was marked as outdated.

@jwhui jwhui changed the title [tests] implement SRP Key Lease (1_3_SRP_TC_4) DinD integration test [tests] implement DinD test for SRP TC 2.6 Name Compression Jun 10, 2026
@jwhui jwhui force-pushed the dind-srp-name-compression-test branch from ab7d107 to 844e266 Compare June 10, 2026 23:07
gemini-code-assist[bot]

This comment was marked as outdated.

@jwhui jwhui force-pushed the dind-srp-name-compression-test branch from 844e266 to bde25f5 Compare June 10, 2026 23:11
@jwhui

jwhui commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces three new integration test scripts (dind_srp_tc_4.exp, dind_srp_tc_5.exp, and dind_srp_tc_6.exp) to verify SRP Key Lease, SRP KEY Record Inclusion/Omission, and SRP Name Compression behaviors respectively. Additionally, the main test runner script test_dind_dns_sd.sh is updated to execute these new test cases. There are no review comments, and I have no feedback to provide.

@jwhui jwhui marked this pull request as ready for review June 10, 2026 23:14
@jwhui jwhui requested a review from abtink June 10, 2026 23:14
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.78%. Comparing base (2b41187) to head (2d88057).
⚠️ Report is 1517 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3411       +/-   ##
===========================================
- Coverage   55.77%   44.78%   -11.00%     
===========================================
  Files          87      143       +56     
  Lines        6890    17277    +10387     
  Branches        0     1417     +1417     
===========================================
+ Hits         3843     7737     +3894     
- Misses       3047     8995     +5948     
- Partials        0      545      +545     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jwhui jwhui force-pushed the dind-srp-name-compression-test branch 2 times, most recently from 739d35b to c69bf37 Compare June 11, 2026 16:29
This commit implements the automated Docker-in-Docker integration test
for SRP Test Case 2.6 (Name Compression) from the Thread test
specification.

Specifically:
- Created dind_srp_tc_6.exp expect script verifying SRP registration,
  unicast DNS PTR query, and mDNS PTR/SRV resolution on the AIL.
- Updated test_dind_dns_sd.sh runner to execute the new test case.
@jwhui jwhui force-pushed the dind-srp-name-compression-test branch from c69bf37 to 2d88057 Compare June 11, 2026 20:01
@jwhui jwhui merged commit 3c9724f into openthread:main Jun 11, 2026
40 checks passed
@jwhui jwhui deleted the dind-srp-name-compression-test branch June 11, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants