[tests] implement DinD test for SRP TC 2.6 Name Compression#3411
Merged
Conversation
ab7d107 to
844e266
Compare
844e266 to
bde25f5
Compare
Member
Author
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces three new integration test scripts (dind_srp_tc_4.exp, dind_srp_tc_5.exp, and dind_srp_tc_6.exp) to verify SRP Key Lease, SRP KEY Record Inclusion/Omission, and SRP Name Compression behaviors respectively. Additionally, the main test runner script test_dind_dns_sd.sh is updated to execute these new test cases. There are no review comments, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3411 +/- ##
===========================================
- Coverage 55.77% 44.78% -11.00%
===========================================
Files 87 143 +56
Lines 6890 17277 +10387
Branches 0 1417 +1417
===========================================
+ Hits 3843 7737 +3894
- Misses 3047 8995 +5948
- Partials 0 545 +545 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
739d35b to
c69bf37
Compare
abtink
approved these changes
Jun 11, 2026
This commit implements the automated Docker-in-Docker integration test for SRP Test Case 2.6 (Name Compression) from the Thread test specification. Specifically: - Created dind_srp_tc_6.exp expect script verifying SRP registration, unicast DNS PTR query, and mDNS PTR/SRV resolution on the AIL. - Updated test_dind_dns_sd.sh runner to execute the new test case.
c69bf37 to
2d88057
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements the Thread 1.3 certification test case 2.4. [1.3] [CERT] Key Lease (1_3_SRP_TC_4) within the Docker-in-Docker testing framework.
Specifically, this adds:
The test verifies that an SRP server correctly enforces key leases by rejecting service name and hostname takeovers when a service lease has expired but the associated key lease remains active (returning YXDomain). It also verifies that takeovers succeed once the key lease fully expires.