Skip to content

[web] Generate QR codes on webUI client instead of remote API#3449

Open
LJspice wants to merge 2 commits into
openthread:mainfrom
LJspice:qrcode-local
Open

[web] Generate QR codes on webUI client instead of remote API#3449
LJspice wants to merge 2 commits into
openthread:mainfrom
LJspice:qrcode-local

Conversation

@LJspice

@LJspice LJspice commented Jun 28, 2026

Copy link
Copy Markdown

Adding one client-executed QR-code generator script to replace the api.qrserver.com call. It didn't seem great or necessary to send thread.pskd out in the existing implementation.

Demo

with change

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the external QR code generation API with a local generator using the qrcode-generator library. This change includes updating the project dependencies in package.json, package-lock.json, CMakeLists.txt, and index.html, and refactoring app.js to handle QR code generation locally within a try-catch block. The review feedback suggests adding defensive checks to ensure that response.data.eui64 and $scope.thread.pskd are defined before generating the QR code, preventing literal 'undefined' or 'null' values from being encoded.

Comment thread src/web/web-service/frontend/res/js/app.js
@LJspice LJspice changed the title Generate QR codes on webUI client instead of remote API [web] Generate QR codes on webUI client instead of remote API Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant