Bump ot-br-posix, openthread and ot-nrf528xx, including the fix for mdns build error - #120
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @yangsong-cnyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the ot-br-posix, openthread, and ot-nrf528xx submodules to their latest versions. These updates are crucial for incorporating OpenThread's built-in DHCPv6 Prefix Delegation client. Additionally, the PR cleans up the otbr-setup script by removing outdated and deprecated NETWORK_MANAGER and DHCPV6_PD build options, streamlining the setup process.
Highlights
- Submodule Updates: Updated openthread to commit a3cd859502cd5df9eb7007cc23e251b0cfac2d6f.
- Submodule Updates: Updated ot-br-posix to commit 781613282ff0b9d87be1fb49c0e33f1542195e7e.
- Submodule Updates: Updated ot-nrf528xx to commit 224d446a39d3d8ead5d806cc265a1f513da76a5c.
- Script Cleanup: Removed deprecated NETWORK_MANAGER=0 and DHCPV6_PD=0 build options from script/otbr-setup.bash.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the openthread, ot-br-posix, and ot-nrf528xx submodules. In conjunction with these updates, it removes the deprecated NETWORK_MANAGER and DHCPV6_PD build options from the otbr-setup.bash script. This change is consistent with the stated goal of using the newer built-in DHCPv6 PD client provided by the updated OpenThread submodule. The changes are clean, well-explained, and appear correct.
0c73195 to
453e875
Compare
yangsong-cnyn
changed the title
ot-br-posix, openthread and ot-nrf528xx, remove network-manager and legacy dhcpv6-pdot-br-posix, openthread and ot-nrf528xx
453e875 to
efbea30
Compare
c54695d to
901b67a
Compare
| * openthread commitid: a3cd859 | ||
| * ot-br-posix commitid: 7816132 | ||
| * ot-nrf528xx commitid: 224d446 |
There was a problem hiding this comment.
Where are the commit IDs from? I couldn't find them.
There was a problem hiding this comment.
it's not updated in time, will correct them
yangsong-cnyn
changed the title
ot-br-posix, openthread and ot-nrf528xxot-br-posix, openthread and ot-nrf528xx, including the fix for mdns build error
901b67a to
2f320f7
Compare
2f320f7 to
93cd391
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates three key OpenThread submodules (openthread, ot-br-posix, and ot-nrf528xx) to newer commit versions and addresses a build configuration issue by explicitly setting the MDNS implementation to mDNSResponder.
- Updates all three OpenThread-related submodules to newer commits
- Fixes build configuration by explicitly setting OTBR_MDNS to mDNSResponder
- Documents the changes in the changelog
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| script/otbr-setup.bash | Adds explicit OTBR_MDNS configuration to prevent build errors |
| ot-nrf528xx | Updates submodule to commit f88ade8 |
| ot-br-posix | Updates submodule to commit 1b2c0f0 |
| openthread | Updates submodule to commit 388f734 |
| CHANGELOG.txt | Documents the submodule updates with new commit IDs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
openthread 388f734b6499d39818912da3a1bbeb4402ba5f48
ot-br-posix 1b2c0f0b223ac176f33f5b85e18845982adfbf1a
ot-nrf528xx f88ade854b693358ebfbbf71adc8716b42adc762
Though default
OTBR_MDNSis changed toopenthreadinotbr-posix, reference release keeps withmDNSResponderAlso, including the fix for build error in
otbr-posixbecause of this change