Skip to content

Bump NCS revision to v3.1.0 - #123

Merged
jwhui merged 1 commit into
openthread:mainfrom
LuDuda:pr/update-310
Sep 4, 2025
Merged

Bump NCS revision to v3.1.0#123
jwhui merged 1 commit into
openthread:mainfrom
LuDuda:pr/update-310

Conversation

@LuDuda

@LuDuda LuDuda commented Aug 27, 2025

Copy link
Copy Markdown
Member

This commit updates NCS revision to v3.1.0 and switches firmware builds to use nrfutil and toolchain-manager instead of a manually installed ARM toolchain.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @LuDuda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the nRF Connect SDK (NCS) to version 3.1.0 and significantly refactoring the firmware build system. The core change involves transitioning from a manual ARM toolchain setup to an automated process leveraging nrfutil and toolchain-manager. This modernization aims to simplify dependency management, streamline the build environment, and ensure compatibility with the latest NCS features. The update also includes minor adjustments to OpenThread configurations.

Highlights

  • NCS Version Bump: The nRF Connect SDK (NCS) version has been updated to v3.1.0, reflecting a significant upgrade in the underlying development environment.
  • Toolchain Management Integration: The firmware build process has been modernized by switching from a manually installed ARM toolchain to using nrfutil and toolchain-manager. This streamlines toolchain setup and management.
  • Build Process Simplification: The build script now automatically handles the installation of necessary build dependencies and Python requirements through the new toolchain management system, simplifying the setup process and reducing manual configuration.
  • OpenThread Configuration Update: A minor configuration change was made in the OpenThread common overlay, enabling CONFIG_OPENTHREAD and removing CONFIG_OPENTHREAD_L2_DEBUG.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the NCS revision to v3.1.0 and refactors the firmware build process to use nrfutil and toolchain-manager. The changes are a good step towards simplifying the toolchain setup. I have provided a few suggestions to improve maintainability by removing a redundant configuration and avoiding hardcoded version strings in the build script. Please see the detailed comments below.

Comment thread config/ncs/overlay-ot-cli-ftd-common.conf
Comment thread script/make-firmware.bash Outdated
Comment thread script/make-firmware.bash Outdated
@jwhui jwhui changed the title Bump NCS revision to v3.1.0. Bump NCS revision to v3.1.0 Aug 29, 2025
@jwhui
jwhui requested a review from Copilot August 29, 2025 04:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the NCS (Nordic Connect SDK) revision from a specific commit hash to version v3.1.0 and modernizes the build process by replacing manual ARM toolchain installation with nrfutil's toolchain-manager.

  • Updates NCS version from commit hash to v3.1.0 tag
  • Replaces manual ARM GCC toolchain setup with nrfutil toolchain-manager
  • Removes deprecated dependency installations and Python requirements setup

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
script/make-firmware.bash Adds nrfutil toolchain management and removes manual toolchain setup
config/ncs/sdk-nrf-commit Updates NCS version reference from commit hash to v3.1.0
config/ncs/overlay-ot-cli-ftd-common.conf Adds CONFIG_OPENTHREAD=y and removes CONFIG_OPENTHREAD_L2_DEBUG=y
.github/workflows/build.yml Removes manual ARM toolchain download and environment setup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread script/make-firmware.bash Outdated
Comment thread script/make-firmware.bash
This commit updates NCS revision to v3.1.0 and switches firmware builds
to use `nrfutil` and `toolchain-manager` instead of a manually installed
ARM toolchain.

Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no>
@jwhui
jwhui merged commit 5129976 into openthread:main Sep 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants