Skip to content

[codex] Add GitHub release asset pipeline mode - #21

Merged
favoyang merged 6 commits into
masterfrom
codex/github-release-asset-pipeline
May 7, 2026
Merged

[codex] Add GitHub release asset pipeline mode#21
favoyang merged 6 commits into
masterfrom
codex/github-release-asset-pipeline

Conversation

@favoyang

@favoyang favoyang commented May 7, 2026

Copy link
Copy Markdown
Member

Summary

Adds a githubRelease package source mode for Azure package publishing. In this mode the queue provides an exact release asset URL/name and the pipeline downloads that tarball directly instead of cloning and packing the repository.

Changes

  • Add packageSource, packageAssetUrl, and packageAssetName pipeline parameters.
  • Keep existing git source behavior as the default.
  • Download GitHub release assets unauthenticated in Azure and emit parseable download-not-found/download-failed errors.
  • Validate downloaded .tgz / .tar.gz package artifacts before publish, including archive shape and package.json name/version.
  • Add GitHub Actions e2e coverage for both git and GitHub release asset modes.

Validation

  • Azure e2e workflow passed for the branch, including the new GitHub release asset fixture.
  • Local pipeline script tests were run during implementation for the new tarball metadata validation coverage.

@favoyang
favoyang marked this pull request as ready for review May 7, 2026 02:25
@favoyang
favoyang merged commit 3204c6c into master May 7, 2026
7 checks passed
@favoyang
favoyang deleted the codex/github-release-asset-pipeline branch May 7, 2026 02:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e575b7f7ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
Comment on lines 45 to +47
if [ -z "${AZURE_DEVOPS_TOKEN_OPENUPM_PIPELINE:-}" ]; then
echo "AZURE_DEVOPS_TOKEN_OPENUPM_PIPELINE is not configured; skipping Azure E2E."
exit 0
echo "AZURE_DEVOPS_TOKEN_OPENUPM_PIPELINE is required for Azure E2E."
exit 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Skip Azure E2E when PAT secret is missing

Failing the workflow when AZURE_DEVOPS_TOKEN_OPENUPM_PIPELINE is unset will break pull_request runs that do not receive repository secrets (for example, fork PRs or bot-originated PRs), causing CI to fail even when code changes are valid. This is a regression from the previous behavior that explicitly skipped Azure E2E without failing, and it conflicts with the documented expectation that the Azure E2E job runs only when that secret is available.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant