Skip to content

fix: accept BOM in package manifests - #24

Merged
favoyang merged 1 commit into
masterfrom
fix-package-json-bom
May 16, 2026
Merged

fix: accept BOM in package manifests#24
favoyang merged 1 commit into
masterfrom
fix-package-json-bom

Conversation

@favoyang

Copy link
Copy Markdown
Member

Summary

  • add a shared package.json reader that strips a leading UTF-8 BOM before parsing
  • use it for package discovery and artifact metadata generation
  • add BOM regression coverage for both paths

Closes openupm/openupm#4135

Validation

  • npm test
  • npm run lint
  • npm run format:check
  • npm run typecheck

@favoyang
favoyang marked this pull request as ready for review May 16, 2026 04:23

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@favoyang
favoyang merged commit 4df5cdd into master May 16, 2026
5 of 7 checks passed
@favoyang
favoyang deleted the fix-package-json-bom branch May 16, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore BOM in package.json when submitting a package

1 participant