Aligned resizeNeighbor key inputs with base class NoteEditState.#2196
Open
rokujyushi wants to merge 1 commit into
Open
Aligned resizeNeighbor key inputs with base class NoteEditState.#2196rokujyushi wants to merge 1 commit into
rokujyushi wants to merge 1 commit into
Conversation
In the `NotesCanvasLeftPointerPressed` method, the `resizeNeighbor` argument was removed from the `NoteResizeEditState` initialization. This led to the removal of the condition `args.KeyModifiers == KeyModifiers.Alt`. In the `NoteResizeEditState` class, the `readonly` modifier for the `resizeNeighbor` field was removed, allowing the value to be changed dynamically. The initialization logic for `resizeNeighbor` was moved from the constructor to the `Update` method, and it is now set based on the `altHeld` state. This aligns the specification with the modifier key input handling in `NoteEditState`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
NotesCanvasLeftPointerPressedmethod, theresizeNeighborargument was removed from theNoteResizeEditStateinitialization. This led to the removal of the conditionargs.KeyModifiers == KeyModifiers.Alt.In the
NoteResizeEditStateclass, thereadonlymodifier for theresizeNeighborfield was removed, allowing the value to be changed dynamically. The initialization logic forresizeNeighborwas moved from the constructor to theUpdatemethod, and it is now set based on thealtHeldstate. This aligns the specification with the modifier key input handling inNoteEditState.