Fix phonetics for 拾 - #730
Merged
Merged
Conversation
The concise dictionary prefers `拾 ㄕㄜˋ` Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%8B%BE#searchL
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds new phrase mappings and alternative pronunciations for the character 拾. The changes include two new two-character phrases (偶拾 and 掘拾) and two alternative pronunciations for existing four-character phrases (拾級而上 and 拾金不昧) using the less common ㄕㄜˋ reading instead of the standard ㄕˊ reading.
- Added two new two-character phrases with frequency 0
- Added alternative pronunciations for two existing four-character phrases using ㄕㄜˋ reading
- Both files properly maintain C locale sorting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Source/Data/phrase.occ | Added frequency entries (0) for new two-character phrases 偶拾 and 掘拾 |
| Source/Data/BPMFMappings.txt | Added Bopomofo mappings for 偶拾, 掘拾, and alternative pronunciations for 拾級而上 and 拾金不昧 using ㄕㄜˋ reading |
lukhnos
requested changes
Nov 13, 2025
This reverts commit 8ceb7f4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The concise dictionary prefers
拾 ㄕㄜˋRef: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%8B%BE#searchL