Skip to content

Fix phonetics for 挾 - #731

Merged
lukhnos merged 3 commits into
openvanilla:masterfrom
xatier:xia
Nov 14, 2025
Merged

Fix phonetics for 挾#731
lukhnos merged 3 commits into
openvanilla:masterfrom
xatier:xia

Conversation

@xatier

@xatier xatier commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

The concise dictionary prefers 挾 ㄒㄧㄚˊ

Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%8C%BE#searchL

Copilot AI review requested due to automatic review settings November 5, 2025 01:43
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new Bopomofo mappings for Chinese phrases containing the heterophony character "挾", including one new phrase "挾嫌" and alternative readings for existing phrases "挾帶" and "要挾".

  • Adds the phrase "挾嫌" with its Bopomofo reading ㄒㄧㄚˊ ㄒㄧㄢˊ
  • Adds alternative Bopomofo reading ㄒㄧㄚˊ ㄉㄞˋ for "挾帶"
  • Adds alternative Bopomofo reading ㄧㄠ ㄒㄧㄚˊ for "要挾"

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
Source/Data/phrase.occ Adds frequency data (0) for the new phrase "挾嫌"
Source/Data/BPMFMappings.txt Adds Bopomofo mappings for "挾嫌" and alternative readings for "挾帶" and "要挾"

Comment thread Source/Data/BPMFMappings.txt
Comment thread Source/Data/BPMFMappings.txt
Comment thread Source/Data/heterophony2.list Outdated
尋 ㄒㄧㄣˊ
屯 ㄓㄨㄣ
待 ㄉㄞ
挾 ㄒㄧㄚˊ

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again let's revert this commit. I think this is where we should make the purpose of heterophony{2,3}.list clearer. When a character-reading pair is added to heterophony1.list, it causes all other homophone readings to be pushed down to a very low score, and for very common characters (think of 中) that can be problematic, and this is where the "promotion by discounting the score of the highest homophone's reading" comes in. Further work on the documentation (and some tweaks of code review agent instructions), I'd say.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done updating the wiki and ask PR makers to ignore automated review suggestions, and made #739.

@lukhnos lukhnos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lukhnos
lukhnos merged commit 6e99a68 into openvanilla:master Nov 14, 2025
7 checks passed
@xatier
xatier deleted the xia branch April 3, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants