Fix phonetics for 挾 - #731
Conversation
The concise dictionary prefers `挾 ㄒㄧㄚˊ` Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%8C%BE#searchL
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds new Bopomofo mappings for Chinese phrases containing the heterophony character "挾", including one new phrase "挾嫌" and alternative readings for existing phrases "挾帶" and "要挾".
- Adds the phrase "挾嫌" with its Bopomofo reading ㄒㄧㄚˊ ㄒㄧㄢˊ
- Adds alternative Bopomofo reading ㄒㄧㄚˊ ㄉㄞˋ for "挾帶"
- Adds alternative Bopomofo reading ㄧㄠ ㄒㄧㄚˊ for "要挾"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Source/Data/phrase.occ | Adds frequency data (0) for the new phrase "挾嫌" |
| Source/Data/BPMFMappings.txt | Adds Bopomofo mappings for "挾嫌" and alternative readings for "挾帶" and "要挾" |
| 尋 ㄒㄧㄣˊ | ||
| 屯 ㄓㄨㄣ | ||
| 待 ㄉㄞ | ||
| 挾 ㄒㄧㄚˊ |
There was a problem hiding this comment.
Again let's revert this commit. I think this is where we should make the purpose of heterophony{2,3}.list clearer. When a character-reading pair is added to heterophony1.list, it causes all other homophone readings to be pushed down to a very low score, and for very common characters (think of 中) that can be problematic, and this is where the "promotion by discounting the score of the highest homophone's reading" comes in. Further work on the documentation (and some tweaks of code review agent instructions), I'd say.
There was a problem hiding this comment.
yes, let's refresh the documentation here https://github.com/openvanilla/McBopomofo/wiki/%E8%A9%9E%E5%BA%AB%E9%96%8B%E7%99%BC%E8%AA%AA%E6%98%8E#%E7%A0%B4%E9%9F%B3%E5%AD%97%E8%A9%9E%E9%A0%BB%E8%AA%BF%E6%95%B4 as well as update the AI reviewer's instructions https://github.com/openvanilla/McBopomofo/blob/master/Source/Data/AGENTS.md#handling-heterophony-characters-%E7%A0%B4%E9%9F%B3%E5%AD%97
Let's be explicit and crystal clear on the expected frequency change behaviors when editing these files.
There was a problem hiding this comment.
Done updating the wiki and ask PR makers to ignore automated review suggestions, and made #739.
This reverts commit 2ea7808.
The concise dictionary prefers
挾 ㄒㄧㄚˊRef: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E6%8C%BE#searchL