Skip to content

Fix SyntaxWarning in regex using raw string - #750

Merged
lukhnos merged 1 commit into
openvanilla:masterfrom
ChiahongHong:regex-warning
Nov 24, 2025
Merged

Fix SyntaxWarning in regex using raw string#750
lukhnos merged 1 commit into
openvanilla:masterfrom
ChiahongHong:regex-warning

Conversation

@ChiahongHong

Copy link
Copy Markdown
Contributor

When running with python -m, Python only shows a given warning once, so the message disappears after the first run unless __pycache__ is removed.

That’s probably why we missed it before. Still, it makes sense to clean this up : )

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @ChiahongHong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This change aims to improve code quality and prevent potential issues by correctly defining a regular expression pattern. By utilizing a raw string, the pull request eliminates a SyntaxWarning that could arise from Python's interpretation of backslashes in string literals, ensuring the regex behaves as intended and avoids future complications with escape sequences.

Highlights

  • SyntaxWarning Resolution: This pull request addresses and resolves a SyntaxWarning that was occurring due to the way a regular expression pattern was defined.
  • Raw String for Regex: The fix involves converting a standard string literal used for a regex pattern into a raw string literal (e.g., r"..."). This ensures that backslashes within the pattern are interpreted literally by the regex engine, preventing Python from processing them as escape sequences first.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a SyntaxWarning in a regular expression by converting the string to a raw string. This is a good practice for all regular expressions in Python to avoid issues with backslash-escaped characters. While reviewing the code, I noticed that the same line of code exists in Source/Data/bin_legacy/cook-plain-bpmf.py. This file appears to be a legacy version of the one being modified. To ensure consistency and prevent future warnings, you might consider applying the same fix to the legacy file or, if it's no longer in use, removing it to reduce code duplication.

@lukhnos lukhnos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lukhnos
lukhnos merged commit 54ef618 into openvanilla:master Nov 24, 2025
8 checks passed
@ChiahongHong
ChiahongHong deleted the regex-warning branch January 31, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants