Fix SyntaxWarning in regex using raw string - #750
Conversation
Summary of ChangesHello @ChiahongHong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This change aims to improve code quality and prevent potential issues by correctly defining a regular expression pattern. By utilizing a raw string, the pull request eliminates a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a SyntaxWarning in a regular expression by converting the string to a raw string. This is a good practice for all regular expressions in Python to avoid issues with backslash-escaped characters. While reviewing the code, I noticed that the same line of code exists in Source/Data/bin_legacy/cook-plain-bpmf.py. This file appears to be a legacy version of the one being modified. To ensure consistency and prevent future warnings, you might consider applying the same fix to the legacy file or, if it's no longer in use, removing it to reduce code duplication.
When running with
python -m, Python only shows a given warning once, so the message disappears after the first run unless__pycache__is removed.That’s probably why we missed it before. Still, it makes sense to clean this up : )