Fix the rank of 子 as ㄗㄜˇ - #765
Conversation
The reading was introduced in openvanilla#644, and this ensures that 怎 always comes first.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adjusts the pronunciation ranking for the character '子' by adding it to heterophony1.list with its common pronunciation ㄗˇ and to heterophony3.list with the rarer pronunciation ㄗㄜˇ. This change correctly uses the heterophony ranking system to influence candidate frequency in the IME. My main feedback is regarding the structure of the data files. Both modified heterophony*.list files are not sorted, while the project's Makefile includes a sort target for this purpose. Keeping these files sorted improves maintainability and helps prevent duplicate entries. I've added comments to the respective files with this suggestion.
There was a problem hiding this comment.
Pull request overview
This pull request fixes the ranking of the character 子 when typed with the Bopomofo reading ㄗㄜˇ by adding it to the heterophony3.list, ensuring that 怎 (a more common character with the same reading) appears first in the candidate list.
- Adds 子 ㄗˇ to heterophony1.list as the default/common reading
- Adds 子 ㄗㄜˇ to heterophony3.list as a less common reading
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Source/Data/heterophony1.list | Adds the default reading 子 ㄗˇ, maintaining C locale sort order |
| Source/Data/heterophony3.list | Adds the rare reading 子 ㄗㄜˇ, maintaining C locale sort order to ensure 怎 has higher priority |
The reading was introduced in #644, and this ensures that 怎 always comes first.